ERP5: do not activate view attachment code by default.

view attachment only works if default_view_reference is specified during the storage creation.

src/jio.storage/erp5storage.js

@@ -94,8 +94,14 @@
   };
 
   ERP5Storage.prototype.allAttachments = function (id) {
+    var context = this;
     return getDocumentAndHateoas(this, id)
       .push(function () {
+        if (context._default_view_reference === undefined) {
+          return {
+            links: {}
+          };
+        }
         return {
           view: {},
           links: {}
@@ -106,6 +112,12 @@
   ERP5Storage.prototype.getAttachment = function (id, action) {
 
     if (action === "view") {
+      if (this._default_view_reference === undefined) {
+        throw new jIO.util.jIOError(
+          "Cannot find attachment view for: " + id,
+          404
+        );
+      }
       return getDocumentAndHateoas(this, id,
                                    {"_view": this._default_view_reference})
         .push(function (response) {

test/jio.storage/erp5storage.tests.js

@@ -221,6 +221,62 @@
     stop();
     expect(10);
 
+    this.jio.allAttachments(id)
+      .then(function (result) {
+        deepEqual(result, {
+          links: {}
+        }, "Check document");
+        equal(server.requests.length, 2);
+        equal(server.requests[0].method, "GET");
+        equal(server.requests[0].url, domain);
+        equal(server.requests[0].requestBody, undefined);
+        equal(server.requests[0].withCredentials, true);
+        equal(server.requests[1].method, "GET");
+        equal(server.requests[1].url, traverse_url);
+        equal(server.requests[1].requestBody, undefined);
+        equal(server.requests[1].withCredentials, true);
+      })
+      .fail(function (error) {
+        ok(false, error);
+      })
+      .always(function () {
+        start();
+      });
+  });
+
+  test("allAttachments ERP5 document with default view", function () {
+    var id = "person_module/20150119_azerty",
+      traverse_url = domain + "?mode=traverse&relative_url=" +
+                     encodeURIComponent(id),
+      document_hateoas = JSON.stringify({
+        // Kept property
+        "title": "foo",
+        // Remove all _ properties
+        "_bar": "john doo",
+        "_links": {
+          type: {
+            name: "Person"
+          }
+        }
+      }),
+      server = this.server;
+
+    this.jio = jIO.createJIO({
+      type: "erp5",
+      url: domain,
+      default_view_reference: "bar_view"
+    });
+
+    this.server.respondWith("GET", domain, [200, {
+      "Content-Type": "application/hal+json"
+    }, root_hateoas]);
+    this.server.respondWith("GET", traverse_url, [200, {
+      "Content-Type": "application/hal+json"
+    }, document_hateoas]);
+
+    stop();
+    expect(10);
+
     this.jio.allAttachments(id)
       .then(function (result) {
         deepEqual(result, {
@@ -466,6 +522,34 @@
       });
   });
 
+  test("getAttachment: view without being specified", function () {
+    var id = "person_module/1";
+
+    this.jio = jIO.createJIO({
+      type: "erp5",
+      url: domain
+    });
+
+    stop();
+    expect(3);
+
+    this.jio.getAttachment(id, "view")
+      .then(function (result) {
+        ok(false, result);
+      })
+      .fail(function (error) {
+        ok(error instanceof jIO.util.jIOError);
+        equal(error.message, "Cannot find attachment view for: " + id);
+        equal(error.status_code, 404);
+      })
+      .fail(function (error) {
+        ok(false, error);
+      })
+      .always(function () {
+        start();
+      });
+  });
+
   test("getAttachment: links on inexistent document", function () {
     var id = "person_module/1",
       traverse_url = domain + "?mode=traverse&relative_url=" +