fix issue #596 'slice is not subclassable'

fix issue #596 'slice is not subclassable'

fix issue #596 'slice is not subclassable'
4a26170b · Dong-hee Na · 92666536 · 4a26170b · 4a26170b
Commit 4a26170b authored Dec 28, 2015 by Dong-hee Na
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

src/runtime/types.cpp src/runtime/types.cpp +1 -0

test/tests/builtin_type_not_subclassable.py test/tests/builtin_type_not_subclassable.py +3 -0

No files found.
--- a/src/runtime/types.cpp
+++ b/src/runtime/types.cpp
@@ -4018,6 +4018,7 @@ void setupRuntime() {
    slice_cls->giveAttr("step", new BoxedMemberDescriptor(BoxedMemberDescriptor::OBJECT, offsetof(BoxedSlice, step)));
    slice_cls->freeze();
    slice_cls->tp_compare = (cmpfunc)slice_compare;
+    slice_cls->tp_flags &= ~Py_TPFLAGS_BASETYPE;

    static PyMappingMethods attrwrapper_as_mapping;
    attrwrapper_cls->tp_as_mapping = &attrwrapper_as_mapping;

--- a/test/tests/builtin_type_not_subclassable.py
+++ b/test/tests/builtin_type_not_subclassable.py
+# should_error
+class foo(slice):
+   pass