Merge pull request #655 from kmod/cpython_test_notes

Take another pass over the failing cpython tests

from_cpython/Lib/test/test_complex_args.py

-# expected: fail
-
 import unittest
 from test import test_support
 import textwrap

from_cpython/Lib/test/test_defaultdict.py

-# expected: fail
 """Unit tests for collections.defaultdict."""
 
 import os

from_cpython/Lib/test/test_filecmp.py

-# expected: fail
-
 import os, filecmp, shutil, tempfile
 import unittest
 from test import test_support

from_cpython/Lib/test/test_opcodes.py

-# expected: fail
 # Python test set -- part 2, opcodes
 
 from test.test_support import run_unittest, check_py3k_warnings

from_cpython/Lib/test/test_popen.py

-# expected: fail
 """Basic tests for os.popen()
 
   Particularly useful for platforms that fake popen.

from_cpython/Lib/test/test_stat.py

-# expected: fail
 import unittest
 import os
 from test.test_support import TESTFN, run_unittest

src/runtime/file.cpp

@@ -1752,7 +1752,7 @@ void setupFile() {
 
     file_cls->giveAttr("flush", new BoxedFunction(boxRTFunction((void*)fileFlush, NONE, 1)));
     file_cls->giveAttr("write", new BoxedFunction(boxRTFunction((void*)fileWrite, NONE, 2)));
-    file_cls->giveAttr("close", new BoxedFunction(boxRTFunction((void*)fileClose, NONE, 1)));
+    file_cls->giveAttr("close", new BoxedFunction(boxRTFunction((void*)fileClose, UNKNOWN, 1)));
     file_cls->giveAttr("fileno", new BoxedFunction(boxRTFunction((void*)fileFileno, BOXED_INT, 1)));
 
     file_cls->giveAttr("__repr__", new BoxedFunction(boxRTFunction((void*)fileRepr, STR, 1)));

test/cpython/NOTES.org

@@ -51,91 +51,83 @@ The CPython tests I've included fail for various reasons. Recurring issues inclu
 ** list of files & why they're failing
 FILE                    REASONS
 ------------------------------------------------------
-test_abstract_numbers   missing .real attribute
-test_augassign          bugs in +=, compile()
+test_augassign          missing oldstyle-class __add__, __iadd__, etc
 test_bisect             somehow sys.modules['_bisect'] is getting set to 0
 test_builtin            execfile scoping issue
-test_coercion           serialize_ast bug (AST node not getting correct lineno or col_offset set)
-test_collections        compile()
-test_compare            segfault
-test_complex            serialize_ast assert
-test_complex_args       we apparently don't always unpack args correctly
-test_contextlib         file.closed, lock.locked attributes
-test_datetime           kwargs bug in BoxedMethodDescriptor
-test_decimal            float.__getformat__
-test_decorators         compile(), func_name attribute, and another bug in test_eval_order
-test_defaultdict        "False is not true"
-test_deque              assert in _collectionsmodule.c
-test_descr              PySequence_Tuple
-test_descrtut           doctest, compile()
-test_dict               infinite recursion in dict.__repr__
-test_dictcomps          compile()
+test_coercion           1**1L, divmod(1, 1L); some unknown bug
+test_collections        doctest (dies in inspect.getmodule())
+test_compare            "AssertionError: 2 != 0.0j"
+test_complex            need complex.__nonzero__
+test_contextlib         lock.locked attributes
+test_datetime           needs _PyObject_GetDictPtr
+test_decimal            I think we need to copy decimaltestdata from cpython
+test_decorators         decorator bug -- we evaluate decorator obj and its args in wrong order
+test_deque              couple unknown issues
+test_descr              wontfix: crashes at "self.__dict__ = self"
+test_descrtut           doctest (dies in inspect.getmodule())
+test_dict               need to handle repr of recursive structures (ie `d = {}; d['self'] = d; print d`)
+test_dictcomps          we need to disallow assigning to dictcomps
 test_dictviews          various unique bugs
-test_doctest            code.co_firstlineno, compile()
-test_doctest2           code.co_firstlineno, compile()
-test_enumerate          wrong assert in BoxedEnumerate
-test_exceptions         segfault in dictIterNext
-test_extcall            doctest (compile())
-test_file               segfaults
-test_file2k             "Someone called abort!"
-test_file_eintr         TypeError
-test_filecmp            float.__hash__
-test_float              capifunc.__name__ in fractions
-test_format             can't float(long)
-test_funcattrs          segfault
-test_functools          segfault
-test_generators         doctest (compile())
-test_genexps            doctest (compile())
-test_getopt             doctest (compile())
-test_global             compile()
+test_doctest            doctest (dies in inspect.getmodule())
+test_doctest2           doctest (sys.displayhook)
+test_enumerate          assert instead of exception in BoxedEnumerate
+test_exceptions         we are missing recursion-depth checking
+test_extcall            doctest (syss.displayhook())
+test_file               wontfix: we don't destruct file objects when the test wants
+test_file2k             we abort when you try to open() a directory
+test_file_eintr         not sure
+test_float              float(long), a couple unknown things
+test_format             float(long)
+test_funcattrs          we don't allow changing numing of function defaults
+test_functools          unknown errors
+test_generators         doctest (sys.displayhook)
+test_genexps            doctest (sys.displayhook)
+test_getopt             doctest (sys.displayhook)
+test_global             SyntaxWarnings for global statements after uses
 test_grammar            bug in our tokenizer
-test_hash               float.__hash__
-test_index              parseSlice assert
-test_int                float.__getformat__
-test_io                 parseSlice assert
-test_json               doctest (compile())
-test_list               assert in sliceIndex to do with a[1L:2L]
-test_long               float.__getformat__
-test_math               float.__getformat__
-test_module             exec in globals_
-test_mutants            needs cmp()
-test_opcodes            TypeError: exceptions must be old-style classes or derived from BaseException, not instance
-test_operator           BoxedCApiFunction::__call__: assert(varargs->elts.size() == 1)
-test_optparse           long.cpp: _longNew: assert(r == 0)
+test_hash               number of hash bugs (all representations of '1' don't have the same hash; empty string is supposed to have 0 hash, etc)
+test_index              slice.indices, old-styl-class __mul__
+test_int                we assert instead of throw exception
+test_io                 memory/gc issue?
+test_json               'from test.script_helper import assert_python_ok' fails; sounds like it is trying to look at pycs
+test_list               longs as slice indices
+test_long               sys.long_info
+test_math               float(long); sys.float_info, sys.displayhook
+test_module             unicode docstrings
+test_mutants            unknown failure
+test_operator           PyNumber_Absolute()
+test_optparse           assertion instead of exceptions for long("invalid number")
 test_pep277             segfaults
 test_pep352             various unique bugs
 test_pkg                unknown bug
-test_popen              objmodel.cpp: callCLFunc: assert(chosen_cfg->spec->rtn_type->isFitBy(r->cls))
-test_pow                global name `pow' is not defined
-test_property           unknown bug
-test_random             floats unhashable
-test_repr               complex.__hash__
-test_richcmp            some missing C API functions
-test_scope              eval of code object
-test_set                list.__hash__
-test_setcomps           doctest (compile())
-test_sets               doctest (compile())
-test_slice              slice.__hash__
-test_sort               listSort(): cmp not supported
-test_stat               16384 != 40960; I guess we implement stat wrong or something?
+test_pow                pow(3L, 3L, -8) fails
+test_random             long("invalid number")
+test_repr               complex.__hash__; some unknown issues
+test_richcmp            PyObject_Not
+test_scope              eval of code object from existing function (not currently supported)
+test_set                weird function-picking issue
+test_setcomps           doctest (sys.displayhook)
+test_sets               doctest (sys.displayhook)
+test_slice              segfault
+test_sort               argument specification issue in listSort?
 test_str                memory leak?
 test_string             infinite loops in test_replace
-test_subprocess         exit code 141, no error message
-test_tuple              parseSlice assert
-test_types              func_name attribute
+test_subprocess         exit code 141 [sigpipe?], no error message
+test_tuple              tuple features: ()*0L, tuple.count, tuple.__getslice__; "test_constructors" fails
+test_types              PyErr_WarnEx
 test_unary              objmodel.cpp: unaryop: Assertion `attr_func' failed: str.__pos__
-test_undocumented_details   cmp()
-test_unicode            sys.maxunicode
+test_undocumented_details   function.func_closure
+test_unicode            argument passing issue?
 test_unicode_file       exit code 139, no error message
 test_unittest           serialize_ast assert
-test_unpack             doctest (compile())
-test_urllib2            doctest (compile())
-test_userdict           segfault
-test_userlist           sliceIndex assert
-test_userstring         std::length_error
-test_uuid               long.cpp: _longNew: assert(r == 0)
-test_weakref            collector.cpp: runCollection: isValidGCObject(head) failed
-test_weakset            set.cpp: setIssubset: assert(container->cls == set_cls)
-test_with               objmodel.cpp: getclsattr: Assertion `gotten' failed: LacksExit:__exit__
-test_wsgiref            ast_interpreter.cpp: createFunction: Assertion `closure' failed.
-test_xrange             xrange of long
+test_unpack             doctest (sys.displayhook)
+test_urllib2            doctest (dies in inspect.getmodule())
+test_userdict           segfault: repr of recursive dict?
+test_userlist           slice(1L, 1L)
+test_userstring         float(1L); hangs in test_replace
+test_uuid               long("invalid number")
+test_weakref            weird function-picking bug (something around float.__add__)
+test_weakset            unknown issues
+test_with               weird codegen assert
+test_wsgiref            unknown issue
+test_xrange             unknown type analysis issue