Merge pull request #1143 from kmod/tester_q

Cherry-pick some tester improvements from the refcounting branch

CMakeLists.txt

@@ -325,7 +325,7 @@ add_test(NAME gc_unittest COMMAND gc_unittest)
 add_test(NAME analysis_unittest COMMAND analysis_unittest)
 
 macro(add_pyston_test testname directory)
-  add_test(NAME pyston_${testname}_${directory} COMMAND ${PYTHON_EXE} ${CMAKE_SOURCE_DIR}/tools/tester.py -R ./pyston -j${TEST_THREADS} -k -a=-S ${ARGV2} ${ARGV3} ${ARGV4} ${CMAKE_SOURCE_DIR}/test/${directory})
+  add_test(NAME pyston_${testname}_${directory} COMMAND ${PYTHON_EXE} ${CMAKE_SOURCE_DIR}/tools/tester.py -R ./pyston -j${TEST_THREADS} -q -k -a=-S ${ARGV2} ${ARGV3} ${ARGV4} ${CMAKE_SOURCE_DIR}/test/${directory})
 endmacro()
 
 # tests         testname directory arguments

tools/tester.py

@@ -42,6 +42,14 @@ EXIT_CODE_ONLY = False
 SKIP_FAILING_TESTS = False
 VERBOSE = 1
 
+DISPLAY_SKIPS = False
+DISPLAY_SUCCESSES = True
+
+def success_message(msg):
+    if DISPLAY_SUCCESSES:
+        return msg
+    return ""
+
 PYTHONIOENCODING = 'utf-8'
 
 # For fun, can test pypy.
@@ -145,7 +153,7 @@ def run_test(fn, check_stats, run_memcheck):
     del check_stats, run_memcheck
 
     if opts.skip:
-        return "(skipped: %s)" % opts.skip
+        return ("(skipped: %s)" % opts.skip) if DISPLAY_SKIPS else ""
 
     env = dict(os.environ)
     env["PYTHONPATH"] = EXTMODULE_DIR_PYSTON
@@ -189,7 +197,9 @@ def get_test_options(fn, check_stats, run_memcheck):
             l = l[len("# run_args:"):].split()
             opts.jit_args += l
         elif l.startswith("# expected:"):
+            assert opts.expected == "success", "Multiple 'expected:' lines found!"
             opts.expected = l[len("# expected:"):].strip()
+            assert opts.expected != "success", "'expected: success' is the default and is ignored"
         elif l.startswith("# should_error"):
             opts.should_error = True
         elif l.startswith("# fail-if:"):
@@ -258,7 +268,9 @@ def determine_test_result(fn, opts, code, out, stderr, elapsed):
             if not have_stats:
                 color = 31
                 msg = "no stats available"
-                if KEEP_GOING:
+                if opts.expected == "fail":
+                    return success_message("Expected failure (no stats found)")
+                elif KEEP_GOING:
                     failed.append(fn)
                     if VERBOSE >= 1:
                         return "\033[%dmFAILED\033[0m (%s)\n%s" % (color, msg, stderr)
@@ -307,7 +319,7 @@ def determine_test_result(fn, opts, code, out, stderr, elapsed):
             msg = "Exited with code %d (expected code %d)" % (code, expected_code)
 
         if opts.expected == "fail":
-            return "Expected failure (got code %d, should be %d)" % (code, expected_code)
+            return success_message("Expected failure (got code %d, should be %d)" % (code, expected_code))
         elif KEEP_GOING:
             failed.append(fn)
             if VERBOSE >= 1:
@@ -333,7 +345,7 @@ def determine_test_result(fn, opts, code, out, stderr, elapsed):
 
     elif out != expected_out:
         if opts.expected == "fail":
-            return "Expected failure (bad output)"
+            return success_message("Expected failure (bad output)")
         else:
             diff = diff_output(expected_out, out, "expected_", "received_")
             if KEEP_GOING:
@@ -347,7 +359,7 @@ def determine_test_result(fn, opts, code, out, stderr, elapsed):
                 raise Exception("Failed on %s:\n%s" % (fn, diff))
     elif not TEST_PYPY and canonicalize_stderr(stderr) != canonicalize_stderr(expected_err):
         if opts.expected == "fail":
-            return "Expected failure (bad stderr)"
+            return success_message("Expected failure (bad stderr)")
         else:
             diff = diff_output(expected_err, stderr, "expectederr_", "receivederr_")
             if KEEP_GOING:
@@ -428,7 +440,7 @@ def determine_test_result(fn, opts, code, out, stderr, elapsed):
         else:
             r += ("(Skipping memchecks)",)
 
-    return r
+    return success_message(r)
 
 q = Queue.Queue()
 cv = threading.Condition()
@@ -476,6 +488,8 @@ parser.add_argument('-s', '--skip-tests', type=str, default='',
                     help='tests to skip (comma-separated)')
 parser.add_argument('-e', '--exit-code-only', action='store_true',
                     help="only check exit code; don't run CPython to get expected output to compare against")
+parser.add_argument('-q', '--quiet', action='store_true',
+                    help="Only display failing tests")
 parser.add_argument('--skip-failing', action='store_true',
                     help="skip tests expected to fail")
 parser.add_argument('--order-by-mtime', action='store_true',
@@ -497,6 +511,7 @@ def main(orig_dir):
     global VERBOSE
     global EXTMODULE_DIR_PYSTON
     global EXTMODULE_DIR
+    global DISPLAY_SUCCESSES
 
     run_memcheck = False
 
@@ -512,6 +527,9 @@ def main(orig_dir):
     EXIT_CODE_ONLY = opts.exit_code_only
     SKIP_FAILING_TESTS = opts.skip_failing
 
+    if opts.quiet:
+        DISPLAY_SUCCESSES = False
+
     TEST_DIR = os.path.join(orig_dir, opts.test_dir)
     EXTMODULE_DIR_PYSTON = os.path.abspath(os.path.dirname(os.path.realpath(IMAGE)) + "/test/test_extension/")
     EXTMODULE_DIR = os.path.abspath(os.path.dirname(os.path.realpath(IMAGE)) + "/test/test_extension/build/lib.linux-x86_64-2.7/")
@@ -598,6 +616,8 @@ def main(orig_dir):
                 print "(%s also failed)" % fn
             sys.exit(1)
             break
+
+        if results[fn]:
             name = os.path.basename(fn).rjust(FN_JUST_SIZE)
             msgs = results[fn]
             if isinstance(msgs,str):