Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
0df662fe
Commit
0df662fe
authored
Jun 14, 2017
by
Fatih Acet
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Implement note awards as a vue component.
parent
7374d2cc
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
141 additions
and
8 deletions
+141
-8
app/assets/javascripts/notes/components/issue_note.vue
app/assets/javascripts/notes/components/issue_note.vue
+0
-7
app/assets/javascripts/notes/components/issue_note_awards_list.vue
...s/javascripts/notes/components/issue_note_awards_list.vue
+124
-0
app/assets/javascripts/notes/components/issue_note_body.vue
app/assets/javascripts/notes/components/issue_note_body.vue
+15
-0
app/views/projects/issues/_discussion.html.haml
app/views/projects/issues/_discussion.html.haml
+2
-1
No files found.
app/assets/javascripts/notes/components/issue_note.vue
View file @
0df662fe
...
@@ -3,7 +3,6 @@ import UserAvatarLink from '../../vue_shared/components/user_avatar/user_avatar_
...
@@ -3,7 +3,6 @@ import UserAvatarLink from '../../vue_shared/components/user_avatar/user_avatar_
import
IssueNoteHeader
from
'
./issue_note_header.vue
'
;
import
IssueNoteHeader
from
'
./issue_note_header.vue
'
;
import
IssueNoteActions
from
'
./issue_note_actions.vue
'
;
import
IssueNoteActions
from
'
./issue_note_actions.vue
'
;
import
IssueNoteBody
from
'
./issue_note_body.vue
'
;
import
IssueNoteBody
from
'
./issue_note_body.vue
'
;
import
IssueNoteEditedText
from
'
./issue_note_edited_text.vue
'
;
export
default
{
export
default
{
props
:
{
props
:
{
...
@@ -17,7 +16,6 @@ export default {
...
@@ -17,7 +16,6 @@ export default {
IssueNoteHeader
,
IssueNoteHeader
,
IssueNoteActions
,
IssueNoteActions
,
IssueNoteBody
,
IssueNoteBody
,
IssueNoteEditedText
,
},
},
computed
:
{
computed
:
{
author
()
{
author
()
{
...
@@ -52,11 +50,6 @@ export default {
...
@@ -52,11 +50,6 @@ export default {
:reportAbusePath=
"note.report_abuse_path"
/>
:reportAbusePath=
"note.report_abuse_path"
/>
</div>
</div>
<issue-note-body
:note=
"note"
/>
<issue-note-body
:note=
"note"
/>
<issue-note-edited-text
v-if=
"note.last_edited_by"
:editedAt=
"note.last_edited_at"
:editedBy=
"note.last_edited_by"
actionText=
"Edited"
/>
</div>
</div>
</div>
</div>
</li>
</li>
...
...
app/assets/javascripts/notes/components/issue_note_awards_list.vue
0 → 100644
View file @
0df662fe
<
script
>
import
{
glEmojiTag
}
from
'
~/behaviors/gl_emoji
'
;
import
emojiSmiling
from
'
../icons/emoji_slightly_smiling_face.svg
'
;
import
emojiSmile
from
'
../icons/emoji_smile.svg
'
;
import
emojiSmiley
from
'
../icons/emoji_smiley.svg
'
;
export
default
{
props
:
{
awards
:
{
type
:
Array
,
required
:
true
,
},
},
data
()
{
return
{
emojiSmiling
,
emojiSmile
,
emojiSmiley
,
};
},
computed
:
{
// `this.awards` is an array with emojis but they are not grouped by emoji name. See below.
// [ { name: foo, user: user1 }, { name: bar, user: user1 }, { name: foo, user: user2 } ]
// This method will group emojis by name their name as an Object. See below.
// {
// foo: [ { name: foo, user: user1 }, { name: foo, user: user2 } ],
// bar: [ { name: bar, user: user1 } ]
// }
// We need to do this otherwise will will render the same emoji over and over again.
groupedAwards
()
{
const
awards
=
{};
this
.
awards
.
forEach
((
award
)
=>
{
awards
[
award
.
name
]
=
awards
[
award
.
name
]
||
[];
awards
[
award
.
name
].
push
(
award
);
});
return
awards
;
},
},
methods
:
{
getAwardHTML
(
name
)
{
return
glEmojiTag
(
name
);
},
amIAwarded
(
awardList
)
{
const
myUserId
=
window
.
gon
.
current_user_id
;
const
isAwarded
=
awardList
.
filter
(
award
=>
award
.
user
.
id
===
myUserId
);
return
isAwarded
.
length
;
},
awardTitle
(
awardsList
)
{
const
amIAwarded
=
this
.
amIAwarded
(
awardsList
);
const
myUserId
=
window
.
gon
.
current_user_id
;
const
TOOLTIP_NAME_COUNT
=
amIAwarded
?
9
:
10
;
let
awardList
=
awardsList
;
if
(
amIAwarded
)
{
awardList
=
awardList
.
filter
(
award
=>
award
.
user
.
id
!==
myUserId
);
}
const
namesToShow
=
awardList
.
slice
(
0
,
TOOLTIP_NAME_COUNT
).
map
(
award
=>
award
.
user
.
name
);
const
remainingAwardList
=
awardList
.
slice
(
TOOLTIP_NAME_COUNT
,
awardList
.
length
);
if
(
amIAwarded
)
{
namesToShow
.
unshift
(
'
You
'
);
}
let
title
=
''
;
if
(
remainingAwardList
.
length
)
{
title
=
`
${
namesToShow
.
join
(
'
,
'
)}
, and
${
remainingAwardList
.
length
}
more.`
;
}
else
if
(
namesToShow
.
length
>
1
)
{
title
=
namesToShow
.
slice
(
0
,
namesToShow
.
length
-
1
).
join
(
'
,
'
);
title
+=
namesToShow
.
length
>
2
?
'
,
'
:
''
;
title
+=
` and
${
namesToShow
.
slice
(
-
1
)}
`
;
}
else
{
title
=
namesToShow
.
join
(
'
and
'
);
}
return
title
;
},
},
};
</
script
>
<
template
>
<div
class=
"note-awards"
>
<div
class=
"awards js-awards-block"
>
<button
v-for=
"(awardList, awardName) in groupedAwards"
class=
"btn award-control has-tooltip"
:class=
"
{ active: amIAwarded(awardList) }"
:title="awardTitle(awardList)"
data-placement="bottom"
type="button">
<span
v-html=
"getAwardHTML(awardName)"
></span>
<span
class=
"award-control-text"
>
{{
awardList
.
length
}}
</span>
</button>
<div
class=
"award-menu-holder"
>
<button
aria-label=
"Add reaction"
class=
"award-control btn has-tooltip"
data-placement=
"bottom"
title=
"Add reaction"
type=
"button"
>
<span
v-html=
"emojiSmiling"
class=
"award-control-icon award-control-icon-neutral"
></span>
<span
v-html=
"emojiSmiley"
class=
"award-control-icon award-control-icon-positive"
></span>
<span
v-html=
"emojiSmile"
class=
"award-control-icon award-control-icon-super-positive"
></span>
<i
aria-hidden=
"true"
class=
"fa fa-spinner fa-spin award-control-icon award-control-icon-loading"
></i>
</button>
</div>
</div>
</div>
</
template
>
app/assets/javascripts/notes/components/issue_note_body.vue
View file @
0df662fe
<
script
>
<
script
>
import
IssueNoteEditedText
from
'
./issue_note_edited_text.vue
'
;
import
IssueNoteAwardsList
from
'
./issue_note_awards_list.vue
'
;
export
default
{
export
default
{
props
:
{
props
:
{
note
:
{
note
:
{
...
@@ -6,6 +9,10 @@ export default {
...
@@ -6,6 +9,10 @@ export default {
required
:
true
,
required
:
true
,
},
},
},
},
components
:
{
IssueNoteEditedText
,
IssueNoteAwardsList
,
},
};
};
</
script
>
</
script
>
...
@@ -14,5 +21,13 @@ export default {
...
@@ -14,5 +21,13 @@ export default {
<div
<div
v-html=
"note.note_html"
v-html=
"note.note_html"
class=
"note-text md"
></div>
class=
"note-text md"
></div>
<issue-note-edited-text
v-if=
"note.last_edited_by"
:editedAt=
"note.last_edited_at"
:editedBy=
"note.last_edited_by"
actionText=
"Edited"
/>
<issue-note-awards-list
v-if=
"note.award_emoji.length"
:awards=
"note.award_emoji"
/>
</div>
</div>
</
template
>
</
template
>
app/views/projects/issues/_discussion.html.haml
View file @
0df662fe
...
@@ -9,5 +9,6 @@
...
@@ -9,5 +9,6 @@
=
webpack_bundle_tag
'common_vue'
=
webpack_bundle_tag
'common_vue'
=
webpack_bundle_tag
'notes'
=
webpack_bundle_tag
'notes'
#notes
#notes
{
style:
"margin-top: 150px"
}
=
render
'shared/notes/notes_with_form'
,
:autocomplete
=>
true
=
render
'shared/notes/notes_with_form'
,
:autocomplete
=>
true
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment