Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
0f0647a1
Commit
0f0647a1
authored
May 09, 2019
by
Alexandru Croitor
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Hide issue title on unsubscribe for anonymous users
parent
4b358114
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
109 additions
and
11 deletions
+109
-11
app/helpers/notifications_helper.rb
app/helpers/notifications_helper.rb
+4
-0
app/views/sent_notifications/unsubscribe.html.haml
app/views/sent_notifications/unsubscribe.html.haml
+1
-1
changelogs/unreleased/security-unsubscribing-from-issue.yml
changelogs/unreleased/security-unsubscribing-from-issue.yml
+5
-0
spec/controllers/sent_notifications_controller_spec.rb
spec/controllers/sent_notifications_controller_spec.rb
+99
-10
No files found.
app/helpers/notifications_helper.rb
View file @
0f0647a1
...
...
@@ -100,4 +100,8 @@ module NotificationsHelper
css_class:
"icon notifications-icon js-notifications-icon"
)
end
def
show_unsubscribe_title?
(
noteable
)
can?
(
current_user
,
"read_
#{
noteable
.
to_ability_name
}
"
.
to_sym
,
noteable
)
end
end
app/views/sent_notifications/unsubscribe.html.haml
View file @
0f0647a1
-
noteable
=
@sent_notification
.
noteable
-
noteable_type
=
@sent_notification
.
noteable_type
.
titleize
.
downcase
-
noteable_text
=
%(#{noteable.title} (#{noteable.to_reference})
)
-
noteable_text
=
show_unsubscribe_title?
(
noteable
)
?
%(#{noteable.title} (#{noteable.to_reference}))
:
%(#{noteable.to_reference}
)
-
page_title
_
(
"Unsubscribe"
),
noteable_text
,
noteable_type
.
pluralize
,
@sent_notification
.
project
.
full_name
%h3
.page-title
...
...
changelogs/unreleased/security-unsubscribing-from-issue.yml
0 → 100644
View file @
0f0647a1
---
title
:
Hide confidential issue title on unsubscribe for anonymous users
merge_request
:
author
:
type
:
security
spec/controllers/sent_notifications_controller_spec.rb
View file @
0f0647a1
...
...
@@ -4,15 +4,31 @@ require 'rails_helper'
describe
SentNotificationsController
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:project
)
{
create
(
:project
)
}
let
(
:sent_notification
)
{
create
(
:sent_notification
,
project:
project
,
noteable:
issue
,
recipient:
user
)
}
let
(
:project
)
{
create
(
:project
,
:public
)
}
let
(
:private_project
)
{
create
(
:project
,
:private
)
}
let
(
:sent_notification
)
{
create
(
:sent_notification
,
project:
target_project
,
noteable:
noteable
,
recipient:
user
)
}
let
(
:issue
)
do
create
(
:issue
,
project:
project
,
author:
user
)
do
|
issue
|
issue
.
subscriptions
.
create
(
user:
user
,
project:
project
,
subscribed:
true
)
create
(
:issue
,
project:
target_project
)
do
|
issue
|
issue
.
subscriptions
.
create
(
user:
user
,
project:
target_
project
,
subscribed:
true
)
end
end
let
(
:confidential_issue
)
do
create
(
:issue
,
project:
target_project
,
confidential:
true
)
do
|
issue
|
issue
.
subscriptions
.
create
(
user:
user
,
project:
target_project
,
subscribed:
true
)
end
end
let
(
:merge_request
)
do
create
(
:merge_request
,
source_project:
target_project
,
target_project:
target_project
)
do
|
mr
|
mr
.
subscriptions
.
create
(
user:
user
,
project:
target_project
,
subscribed:
true
)
end
end
let
(
:noteable
)
{
issue
}
let
(
:target_project
)
{
project
}
describe
'GET unsubscribe'
do
context
'when the user is not logged in'
do
context
'when the force param is passed'
do
...
...
@@ -34,22 +50,95 @@ describe SentNotificationsController do
end
context
'when the force param is not passed'
do
render_views
before
do
get
(
:unsubscribe
,
params:
{
id:
sent_notification
.
reply_key
})
end
shared_examples
'unsubscribing as anonymous'
do
it
'does not unsubscribe the user'
do
expect
(
issue
.
subscribed?
(
user
,
project
)).
to
be_truthy
expect
(
noteable
.
subscribed?
(
user
,
target_
project
)).
to
be_truthy
end
it
'does not set the flash message'
do
expect
(
controller
).
not_to
set_flash
[
:notice
]
end
it
'redirects to the login page'
do
it
'renders unsubscribe page'
do
expect
(
response
.
status
).
to
eq
(
200
)
expect
(
response
).
to
render_template
:unsubscribe
end
end
context
'when project is public'
do
context
'when unsubscribing from issue'
do
let
(
:noteable
)
{
issue
}
it
'shows issue title'
do
expect
(
response
.
body
).
to
include
(
issue
.
title
)
end
it_behaves_like
'unsubscribing as anonymous'
end
context
'when unsubscribing from confidential issue'
do
let
(
:noteable
)
{
confidential_issue
}
it
'does not show issue title'
do
expect
(
response
.
body
).
not_to
include
(
confidential_issue
.
title
)
expect
(
response
.
body
).
to
include
(
confidential_issue
.
to_reference
)
end
it_behaves_like
'unsubscribing as anonymous'
end
context
'when unsubscribing from merge request'
do
let
(
:noteable
)
{
merge_request
}
it
'shows merge request title'
do
expect
(
response
.
body
).
to
include
(
merge_request
.
title
)
end
it_behaves_like
'unsubscribing as anonymous'
end
end
context
'when project is not public'
do
let
(
:target_project
)
{
private_project
}
context
'when unsubscribing from issue'
do
let
(
:noteable
)
{
issue
}
it
'shows issue title'
do
expect
(
response
.
body
).
not_to
include
(
issue
.
title
)
end
it_behaves_like
'unsubscribing as anonymous'
end
context
'when unsubscribing from confidential issue'
do
let
(
:noteable
)
{
confidential_issue
}
it
'does not show issue title'
do
expect
(
response
.
body
).
not_to
include
(
confidential_issue
.
title
)
expect
(
response
.
body
).
to
include
(
confidential_issue
.
to_reference
)
end
it_behaves_like
'unsubscribing as anonymous'
end
context
'when unsubscribing from merge request'
do
let
(
:noteable
)
{
merge_request
}
it
'shows merge request title'
do
expect
(
response
.
body
).
not_to
include
(
merge_request
.
title
)
end
it_behaves_like
'unsubscribing as anonymous'
end
end
end
end
context
'when the user is logged in'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment