diff --git a/spec/lib/gitlab/backup/repository_spec.rb b/spec/lib/gitlab/backup/repository_spec.rb index 3d4bc39e17cd1527e0f3185e1c6657fdc56dc1b2..5399b4ac805f568c1320b3b6a9fd8ce64ef34d86 100644 --- a/spec/lib/gitlab/backup/repository_spec.rb +++ b/spec/lib/gitlab/backup/repository_spec.rb @@ -22,14 +22,49 @@ describe Backup::Repository, lib: true do $progress = @old_progress # rubocop:disable Style/GlobalVars end - describe 'repo failure' do - before do - allow_any_instance_of(Project).to receive(:empty_repo?).and_raise(Rugged::OdbError) - allow(Gitlab::Popen).to receive(:popen).and_return(['normal output', 0]) + describe '.dump' do + describe 'repo failure' do + before do + allow_any_instance_of(Project).to receive(:empty_repo?).and_raise(Rugged::OdbError) + allow(Gitlab::Popen).to receive(:popen).and_return(['normal output', 0]) + end + + it 'does not raise error' do + expect { described_class.new.dump }.not_to raise_error + end + + it 'shows the appropriate error' do + described_class.new.dump + + expect(progress).to have_received(:puts).with("Ignoring error on #{project.full_path} repository - Rugged::OdbError") + end + end + + describe 'command failure' do + before do + allow_any_instance_of(Project).to receive(:empty_repo?).and_return(false) + allow(Gitlab::Popen).to receive(:popen).and_return(['error', 1]) + end + + it 'shows the appropriate error' do + described_class.new.dump + + expect(progress).to have_received(:puts).with("Ignoring error on #{project.full_path} - error") + end end + end + + describe '.restore' do + describe 'command failure' do + before do + allow(Gitlab::Popen).to receive(:popen).and_return(['error', 1]) + end + + it 'shows the appropriate error' do + described_class.new.restore - it 'does not raise error' do - expect { described_class.new.dump }.not_to raise_error + expect(progress).to have_received(:puts).with("Ignoring error on #{project.full_path} - error") + end end end end