Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
1c73d302
Commit
1c73d302
authored
Sep 20, 2016
by
Douglas Barbosa Alexandre
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Avoid an extra a query per label when setting label priority
parent
b10e5764
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
2 deletions
+3
-2
app/controllers/projects/labels_controller.rb
app/controllers/projects/labels_controller.rb
+3
-2
No files found.
app/controllers/projects/labels_controller.rb
View file @
1c73d302
...
...
@@ -97,8 +97,9 @@ class Projects::LabelsController < Projects::ApplicationController
def
set_priorities
Label
.
transaction
do
params
[
:label_ids
].
each_with_index
do
|
label_id
,
index
|
label
=
labels
.
find_by_id
(
label_id
)
label
.
update_attribute
(
:priority
,
index
)
if
label
next
unless
labels
.
where
(
id:
label_id
).
any?
Label
.
where
(
id:
label_id
).
update_all
(
priority:
index
)
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment