Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
213ee624
Commit
213ee624
authored
8 years ago
by
Jacob Vosmaer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Be careful when setting class instance vars
parent
0163e276
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
2 deletions
+13
-2
lib/gitlab/redis.rb
lib/gitlab/redis.rb
+13
-2
No files found.
lib/gitlab/redis.rb
View file @
213ee624
...
...
@@ -2,12 +2,23 @@ module Gitlab
class
Redis
attr_reader
:url
# To be thread-safe we must be careful when writing the class instance
# variables @url and @pool. Because @pool depends on @url we need two
# mutexes to prevent deadlock.
URL_MUTEX
=
Mutex
.
new
POOL_MUTEX
=
Mutex
.
new
private_constant
:URL_MUTEX
,
:POOL_MUTEX
def
self
.
url
@url
||
=
new
.
url
@url
||
URL_MUTEX
.
synchronize
{
@url
=
new
.
url
}
end
def
self
.
with
@pool
||=
ConnectionPool
.
new
{
::
Redis
.
new
(
url:
url
)
}
if
@pool
.
nil?
POOL_MUTEX
.
synchronize
do
@pool
=
ConnectionPool
.
new
{
::
Redis
.
new
(
url:
url
)
}
end
end
@pool
.
with
{
|
redis
|
yield
redis
}
end
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment