Commit 22caeb58 authored by Nick Thomas's avatar Nick Thomas

Merge branch 'ce-reduce-diff-in-groups-update_service' into 'master'

Reduce diff with EE in Groups::UpdateService

See merge request gitlab-org/gitlab-ce!24912
parents 699806ba 4e7dd94d
...@@ -11,6 +11,8 @@ module Groups ...@@ -11,6 +11,8 @@ module Groups
return false unless valid_share_with_group_lock_change? return false unless valid_share_with_group_lock_change?
before_assignment_hook(group, params)
group.assign_attributes(params) group.assign_attributes(params)
begin begin
...@@ -28,6 +30,10 @@ module Groups ...@@ -28,6 +30,10 @@ module Groups
private private
def before_assignment_hook(group, params)
# overriden in EE
end
def after_update def after_update
if group.previous_changes.include?(:visibility_level) && group.private? if group.previous_changes.include?(:visibility_level) && group.private?
# don't enqueue immediately to prevent todos removal in case of a mistake # don't enqueue immediately to prevent todos removal in case of a mistake
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment