Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
2d56c8fd
Commit
2d56c8fd
authored
Jul 23, 2018
by
Filipa Lacerda - 🌴🌴OOO back on July 30th🌴🌴
Committed by
Phil Hughes
Jul 23, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adds Vuex store to handle the data for tests reports in MR widget
parent
4636bebb
Changes
8
Show whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
375 additions
and
0 deletions
+375
-0
app/assets/javascripts/reports/store/actions.js
app/assets/javascripts/reports/store/actions.js
+67
-0
app/assets/javascripts/reports/store/index.js
app/assets/javascripts/reports/store/index.js
+13
-0
app/assets/javascripts/reports/store/mutation_types.js
app/assets/javascripts/reports/store/mutation_types.js
+5
-0
app/assets/javascripts/reports/store/mutations.js
app/assets/javascripts/reports/store/mutations.js
+26
-0
app/assets/javascripts/reports/store/state.js
app/assets/javascripts/reports/store/state.js
+28
-0
changelogs/unreleased/45318-vuex-store.yml
changelogs/unreleased/45318-vuex-store.yml
+5
-0
spec/javascripts/reports/store/actions_spec.js
spec/javascripts/reports/store/actions_spec.js
+130
-0
spec/javascripts/reports/store/mutations_spec.js
spec/javascripts/reports/store/mutations_spec.js
+101
-0
No files found.
app/assets/javascripts/reports/store/actions.js
0 → 100644
View file @
2d56c8fd
import
Visibility
from
'
visibilityjs
'
;
import
axios
from
'
../../lib/utils/axios_utils
'
;
import
Poll
from
'
../../lib/utils/poll
'
;
import
*
as
types
from
'
./mutation_types
'
;
export
const
setEndpoint
=
({
commit
},
endpoint
)
=>
commit
(
types
.
SET_ENDPOINT
,
endpoint
);
export
const
requestReports
=
({
commit
})
=>
commit
(
types
.
REQUEST_REPORTS
);
let
eTagPoll
;
export
const
clearEtagPoll
=
()
=>
{
eTagPoll
=
null
;
};
export
const
stopPolling
=
()
=>
{
if
(
eTagPoll
)
eTagPoll
.
stop
();
};
export
const
restartPolling
=
()
=>
{
if
(
eTagPoll
)
eTagPoll
.
restart
();
};
/**
* We need to poll the reports endpoint while they are being parsed in the Backend.
* This can take up to one minute.
*
* Poll.js will handle etag response.
* While http status code is 204, it means it's parsing, and we'll keep polling
* When http status code is 200, it means parsing is done, we can show the results & stop polling
* When http status code is 500, it means parsing went wrong and we stop polling
*/
export
const
fetchReports
=
({
state
,
dispatch
})
=>
{
dispatch
(
'
requestReports
'
);
eTagPoll
=
new
Poll
({
resource
:
{
getReports
(
endpoint
)
{
return
axios
.
get
(
endpoint
);
},
},
data
:
state
.
endpoint
,
method
:
'
getReports
'
,
successCallback
:
({
data
})
=>
dispatch
(
'
receiveReportsSuccess
'
,
data
),
errorCallback
:
()
=>
dispatch
(
'
receiveReportsError
'
),
});
if
(
!
Visibility
.
hidden
())
{
eTagPoll
.
makeRequest
();
}
Visibility
.
change
(()
=>
{
if
(
!
Visibility
.
hidden
())
{
dispatch
(
'
restartPolling
'
);
}
else
{
dispatch
(
'
stopPolling
'
);
}
});
};
export
const
receiveReportsSuccess
=
({
commit
},
response
)
=>
commit
(
types
.
RECEIVE_REPORTS_SUCCESS
,
response
);
export
const
receiveReportsError
=
({
commit
})
=>
commit
(
types
.
RECEIVE_REPORTS_ERROR
);
// prevent babel-plugin-rewire from generating an invalid default during karma tests
export
default
()
=>
{};
app/assets/javascripts/reports/store/index.js
0 → 100644
View file @
2d56c8fd
import
Vue
from
'
vue
'
;
import
Vuex
from
'
vuex
'
;
import
*
as
actions
from
'
./actions
'
;
import
mutations
from
'
./mutations
'
;
import
state
from
'
./state
'
;
Vue
.
use
(
Vuex
);
export
default
()
=>
new
Vuex
.
Store
({
actions
,
mutations
,
state
:
state
(),
});
app/assets/javascripts/reports/store/mutation_types.js
0 → 100644
View file @
2d56c8fd
export
const
SET_ENDPOINT
=
'
SET_ENDPOINT
'
;
export
const
REQUEST_REPORTS
=
'
REQUEST_REPORTS
'
;
export
const
RECEIVE_REPORTS_SUCCESS
=
'
RECEIVE_REPORTS_SUCCESS
'
;
export
const
RECEIVE_REPORTS_ERROR
=
'
RECEIVE_REPORTS_ERROR
'
;
app/assets/javascripts/reports/store/mutations.js
0 → 100644
View file @
2d56c8fd
/* eslint-disable no-param-reassign */
import
*
as
types
from
'
./mutation_types
'
;
export
default
{
[
types
.
SET_ENDPOINT
](
state
,
endpoint
)
{
state
.
endpoint
=
endpoint
;
},
[
types
.
REQUEST_REPORTS
](
state
)
{
state
.
isLoading
=
true
;
},
[
types
.
RECEIVE_REPORTS_SUCCESS
](
state
,
response
)
{
state
.
isLoading
=
false
;
state
.
summary
.
total
=
response
.
summary
.
total
;
state
.
summary
.
resolved
=
response
.
summary
.
resolved
;
state
.
summary
.
failed
=
response
.
summary
.
failed
;
state
.
reports
=
response
.
suites
;
},
[
types
.
RECEIVE_REPORTS_ERROR
](
state
)
{
state
.
isLoading
=
false
;
state
.
hasError
=
true
;
},
};
app/assets/javascripts/reports/store/state.js
0 → 100644
View file @
2d56c8fd
export
default
()
=>
({
endpoint
:
null
,
isLoading
:
false
,
hasError
:
false
,
summary
:
{
total
:
0
,
resolved
:
0
,
failed
:
0
,
},
/**
* Each report will have the following format:
* {
* name: {String},
* summary: {
* total: {Number},
* resolved: {Number},
* failed: {Number},
* },
* new_failures: {Array.<Object>},
* resolved_failures: {Array.<Object>},
* existing_failures: {Array.<Object>},
* }
*/
reports
:
[],
});
changelogs/unreleased/45318-vuex-store.yml
0 → 100644
View file @
2d56c8fd
---
title
:
Adds Vuex store for reports section in MR widget
merge_request
:
20709
author
:
type
:
added
spec/javascripts/reports/store/actions_spec.js
0 → 100644
View file @
2d56c8fd
import
MockAdapter
from
'
axios-mock-adapter
'
;
import
axios
from
'
~/lib/utils/axios_utils
'
;
import
{
setEndpoint
,
requestReports
,
fetchReports
,
stopPolling
,
clearEtagPoll
,
receiveReportsSuccess
,
receiveReportsError
,
}
from
'
~/reports/store/actions
'
;
import
state
from
'
~/reports/store/state
'
;
import
*
as
types
from
'
~/reports/store/mutation_types
'
;
import
testAction
from
'
spec/helpers/vuex_action_helper
'
;
import
{
TEST_HOST
}
from
'
spec/test_constants
'
;
describe
(
'
Reports Store Actions
'
,
()
=>
{
let
mockedState
;
beforeEach
(()
=>
{
mockedState
=
state
();
});
describe
(
'
setEndpoint
'
,
()
=>
{
it
(
'
should commit SET_ENDPOINT mutation
'
,
done
=>
{
testAction
(
setEndpoint
,
'
endpoint.json
'
,
mockedState
,
[{
type
:
types
.
SET_ENDPOINT
,
payload
:
'
endpoint.json
'
}],
[],
done
,
);
});
});
describe
(
'
requestReports
'
,
()
=>
{
it
(
'
should commit REQUEST_REPORTS mutation
'
,
done
=>
{
testAction
(
requestReports
,
null
,
mockedState
,
[{
type
:
types
.
REQUEST_REPORTS
}],
[],
done
);
});
});
describe
(
'
fetchReports
'
,
()
=>
{
let
mock
;
beforeEach
(()
=>
{
mockedState
.
endpoint
=
`
${
TEST_HOST
}
/endpoint.json`
;
mock
=
new
MockAdapter
(
axios
);
});
afterEach
(()
=>
{
mock
.
restore
();
stopPolling
();
clearEtagPoll
();
});
describe
(
'
success
'
,
()
=>
{
it
(
'
dispatches requestReports and receiveReportsSuccess
'
,
done
=>
{
mock
.
onGet
(
`
${
TEST_HOST
}
/endpoint.json`
).
replyOnce
(
200
,
{
summary
:
{},
suites
:
[{
name
:
'
rspec
'
}]
});
testAction
(
fetchReports
,
null
,
mockedState
,
[],
[
{
type
:
'
requestReports
'
,
},
{
payload
:
{
summary
:
{},
suites
:
[{
name
:
'
rspec
'
}]
},
type
:
'
receiveReportsSuccess
'
,
},
],
done
,
);
});
});
describe
(
'
error
'
,
()
=>
{
beforeEach
(()
=>
{
mock
.
onGet
(
`
${
TEST_HOST
}
/endpoint.json`
).
reply
(
500
);
});
it
(
'
dispatches requestReports and receiveReportsError
'
,
done
=>
{
testAction
(
fetchReports
,
null
,
mockedState
,
[],
[
{
type
:
'
requestReports
'
,
},
{
type
:
'
receiveReportsError
'
,
},
],
done
,
);
});
});
});
describe
(
'
receiveReportsSuccess
'
,
()
=>
{
it
(
'
should commit RECEIVE_REPORTS_SUCCESS mutation
'
,
done
=>
{
testAction
(
receiveReportsSuccess
,
{
summary
:
{}
},
mockedState
,
[{
type
:
types
.
RECEIVE_REPORTS_SUCCESS
,
payload
:
{
summary
:
{}
}
}],
[],
done
,
);
});
});
describe
(
'
receiveReportsError
'
,
()
=>
{
it
(
'
should commit RECEIVE_REPORTS_ERROR mutation
'
,
done
=>
{
testAction
(
receiveReportsError
,
null
,
mockedState
,
[{
type
:
types
.
RECEIVE_REPORTS_ERROR
}],
[],
done
,
);
});
});
});
spec/javascripts/reports/store/mutations_spec.js
0 → 100644
View file @
2d56c8fd
import
state
from
'
~/reports/store/state
'
;
import
mutations
from
'
~/reports/store/mutations
'
;
import
*
as
types
from
'
~/reports/store/mutation_types
'
;
describe
(
'
Reports Store Mutations
'
,
()
=>
{
let
stateCopy
;
beforeEach
(()
=>
{
stateCopy
=
state
();
});
describe
(
'
SET_ENDPOINT
'
,
()
=>
{
it
(
'
should set endpoint
'
,
()
=>
{
mutations
[
types
.
SET_ENDPOINT
](
stateCopy
,
'
endpoint.json
'
);
expect
(
stateCopy
.
endpoint
).
toEqual
(
'
endpoint.json
'
);
});
});
describe
(
'
REQUEST_REPORTS
'
,
()
=>
{
it
(
'
should set isLoading to true
'
,
()
=>
{
mutations
[
types
.
REQUEST_REPORTS
](
stateCopy
);
expect
(
stateCopy
.
isLoading
).
toEqual
(
true
);
});
});
describe
(
'
RECEIVE_REPORTS_SUCCESS
'
,
()
=>
{
const
mockedResponse
=
{
summary
:
{
total
:
14
,
resolved
:
0
,
failed
:
7
,
},
suites
:
[
{
name
:
'
build:linux
'
,
summary
:
{
total
:
2
,
resolved
:
0
,
failed
:
1
,
},
new_failures
:
[
{
name
:
'
StringHelper#concatenate when a is git and b is lab returns summary
'
,
execution_time
:
0.0092435
,
system_output
:
'
Failure/Error: is_expected.to eq(
\'
gitlab
\'
)
'
,
},
],
resolved_failures
:
[
{
name
:
'
StringHelper#concatenate when a is git and b is lab returns summary
'
,
execution_time
:
0.009235
,
system_output
:
'
Failure/Error: is_expected.to eq(
\'
gitlab
\'
)
'
,
},
],
existing_failures
:
[
{
name
:
'
StringHelper#concatenate when a is git and b is lab returns summary
'
,
execution_time
:
1232.08
,
system_output
:
'
Failure/Error: is_expected.to eq(
\'
gitlab
\'
)
'
,
},
],
},
],
};
beforeEach
(()
=>
{
mutations
[
types
.
RECEIVE_REPORTS_SUCCESS
](
stateCopy
,
mockedResponse
);
});
it
(
'
should reset isLoading
'
,
()
=>
{
expect
(
stateCopy
.
isLoading
).
toEqual
(
false
);
});
it
(
'
should set summary counts
'
,
()
=>
{
expect
(
stateCopy
.
summary
.
total
).
toEqual
(
mockedResponse
.
summary
.
total
);
expect
(
stateCopy
.
summary
.
resolved
).
toEqual
(
mockedResponse
.
summary
.
resolved
);
expect
(
stateCopy
.
summary
.
failed
).
toEqual
(
mockedResponse
.
summary
.
failed
);
});
it
(
'
should set reports
'
,
()
=>
{
expect
(
stateCopy
.
reports
).
toEqual
(
mockedResponse
.
suites
);
});
});
describe
(
'
RECEIVE_REPORTS_ERROR
'
,
()
=>
{
beforeEach
(()
=>
{
mutations
[
types
.
RECEIVE_REPORTS_ERROR
](
stateCopy
);
});
it
(
'
should reset isLoading
'
,
()
=>
{
expect
(
stateCopy
.
isLoading
).
toEqual
(
false
);
});
it
(
'
should set hasError to true
'
,
()
=>
{
expect
(
stateCopy
.
hasError
).
toEqual
(
true
);
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment