Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
2f7fc7e9
Commit
2f7fc7e9
authored
Oct 20, 2015
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Prefer project with exact path to differently cased one when both exist.
parent
97eafd4b
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
38 additions
and
13 deletions
+38
-13
app/controllers/application_controller.rb
app/controllers/application_controller.rb
+2
-2
app/models/project.rb
app/models/project.rb
+12
-5
spec/controllers/projects_controller_spec.rb
spec/controllers/projects_controller_spec.rb
+24
-6
No files found.
app/controllers/application_controller.rb
View file @
2f7fc7e9
...
@@ -118,8 +118,8 @@ class ApplicationController < ActionController::Base
...
@@ -118,8 +118,8 @@ class ApplicationController < ActionController::Base
end
end
project_path
=
"
#{
namespace
}
/
#{
id
}
"
project_path
=
"
#{
namespace
}
/
#{
id
}
"
@project
=
Project
.
find_with_namespace
(
project_path
)
@project
=
Project
.
find_with_namespace
(
project_path
)
||
Project
.
find_with_namespace
(
project_path
,
case_sensitive:
false
)
if
@project
and
can?
(
current_user
,
:read_project
,
@project
)
if
@project
and
can?
(
current_user
,
:read_project
,
@project
)
if
@project
.
path_with_namespace
!=
project_path
if
@project
.
path_with_namespace
!=
project_path
...
...
app/models/project.rb
View file @
2f7fc7e9
...
@@ -235,7 +235,7 @@ class Project < ActiveRecord::Base
...
@@ -235,7 +235,7 @@ class Project < ActiveRecord::Base
where
(
'projects.archived = ?'
,
false
).
where
(
'LOWER(projects.name) LIKE :query'
,
query:
"%
#{
query
.
downcase
}
%"
)
where
(
'projects.archived = ?'
,
false
).
where
(
'LOWER(projects.name) LIKE :query'
,
query:
"%
#{
query
.
downcase
}
%"
)
end
end
def
find_with_namespace
(
id
)
def
find_with_namespace
(
id
,
case_sensitive:
true
)
namespace_path
,
project_path
=
id
.
split
(
'/'
)
namespace_path
,
project_path
=
id
.
split
(
'/'
)
return
nil
if
!
namespace_path
||
!
project_path
return
nil
if
!
namespace_path
||
!
project_path
...
@@ -243,11 +243,18 @@ class Project < ActiveRecord::Base
...
@@ -243,11 +243,18 @@ class Project < ActiveRecord::Base
# Use of unscoped ensures we're not secretly adding any ORDER BYs, which
# Use of unscoped ensures we're not secretly adding any ORDER BYs, which
# have a negative impact on performance (and aren't needed for this
# have a negative impact on performance (and aren't needed for this
# query).
# query).
unscoped
.
projects
=
unscoped
.
joins
(
:namespace
).
joins
(
:namespace
).
iwhere
(
'namespaces.path'
=>
namespace_path
).
iwhere
(
'namespaces.path'
=>
namespace_path
)
iwhere
(
'projects.path'
=>
project_path
).
take
projects
=
if
case_sensitive
projects
.
where
(
'projects.path'
=>
project_path
)
else
projects
.
iwhere
(
'projects.path'
=>
project_path
)
end
projects
.
take
end
end
def
visibility_levels
def
visibility_levels
...
...
spec/controllers/projects_controller_spec.rb
View file @
2f7fc7e9
...
@@ -51,19 +51,37 @@ describe ProjectsController do
...
@@ -51,19 +51,37 @@ describe ProjectsController do
end
end
context
"when requested with case sensitive namespace and project path"
do
context
"when requested with case sensitive namespace and project path"
do
it
"redirects to the normalized path for case mismatch"
do
context
"when there is a match with the same casing"
do
it
"loads the project"
do
get
:show
,
namespace_id:
public_project
.
namespace
.
path
,
id:
public_project
.
path
expect
(
assigns
(
:project
)).
to
eq
(
public_project
)
expect
(
response
.
status
).
to
eq
(
200
)
end
end
context
"when there is a match with different casing"
do
it
"redirects to the normalized path"
do
get
:show
,
namespace_id:
public_project
.
namespace
.
path
,
id:
public_project
.
path
.
upcase
get
:show
,
namespace_id:
public_project
.
namespace
.
path
,
id:
public_project
.
path
.
upcase
expect
(
assigns
(
:project
)).
to
eq
(
public_project
)
expect
(
response
).
to
redirect_to
(
"/
#{
public_project
.
path_with_namespace
}
"
)
expect
(
response
).
to
redirect_to
(
"/
#{
public_project
.
path_with_namespace
}
"
)
end
end
it
"loads the page if normalized path matches request path"
do
context
"when there is also a match with the same casing"
do
get
:show
,
namespace_id:
public_project
.
namespace
.
path
,
id:
public_project
.
path
let!
(
:other_project
)
{
create
(
:project
,
:public
,
namespace:
public_project
.
namespace
,
path:
public_project
.
path
.
upcase
)
}
it
"loads the exactly matched project"
do
get
:show
,
namespace_id:
public_project
.
namespace
.
path
,
id:
public_project
.
path
.
upcase
expect
(
assigns
(
:project
)).
to
eq
(
other_project
)
expect
(
response
.
status
).
to
eq
(
200
)
expect
(
response
.
status
).
to
eq
(
200
)
end
end
end
end
end
end
end
end
describe
"POST #toggle_star"
do
describe
"POST #toggle_star"
do
it
"toggles star if user is signed in"
do
it
"toggles star if user is signed in"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment