From 4c3482345a3bcc9ac5d29f5dbc55c966ca5a0c72 Mon Sep 17 00:00:00 2001
From: Tomasz Maczukin <tomasz@maczukin.pl>
Date: Wed, 7 Mar 2018 23:53:15 +0100
Subject: [PATCH] Fix sidebar_detail_row_spec.js

---
 .../jobs/sidebar_detail_row_spec.js           | 34 +++++++++++--------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/spec/javascripts/jobs/sidebar_detail_row_spec.js b/spec/javascripts/jobs/sidebar_detail_row_spec.js
index 9fe5cf78b8b..e6bfb0c4adc 100644
--- a/spec/javascripts/jobs/sidebar_detail_row_spec.js
+++ b/spec/javascripts/jobs/sidebar_detail_row_spec.js
@@ -38,20 +38,24 @@ describe('Sidebar detail row', () => {
     ).toEqual('this is the title: this is the value');
   });
 
-  it('should not render help when helpUrl not provided', () => {
-    expect(vm.$el.querySelector('.help-button')).toBeUndefined();
-  });
-
-  beforeEach(() => {
-    vm = new SidebarDetailRow({
-      propsData: {
-        helpUrl: 'help url',
-        value: 'foo',
-      },
-    }).$mount();
-  });
-
-  it('should render help when helpUrl is provided', () => {
-    expect(vm.$el.querySelector('.help-button a').getAttribute('href')).toEqual('help url');
+  describe('when helpUrl not provided', () => {
+    it('should not render help', () => {
+      expect(vm.$el.querySelector('.help-button')).toBeNull();
+    });
+  });
+
+  describe('when helpUrl provided', () => {
+    beforeEach(() => {
+      vm = new SidebarDetailRow({
+        propsData: {
+          helpUrl: 'help url',
+          value: 'foo',
+        },
+      }).$mount();
+    });
+
+    it('should render help', () => {
+      expect(vm.$el.querySelector('.help-button a').getAttribute('href')).toEqual('help url');
+    });
   });
 });
-- 
2.30.9