Changes after review

app/assets/javascripts/environments/components/environment.js

@@ -132,8 +132,6 @@ export default Vue.component('environment-component', {
         .then(resp => resp.json())
         .then((response) => {
           this.store.setfolderContent(folder, response.environments);
-        })
-        .then(() => {
           this.isLoadingFolderContent = false;
         })
         .catch(() => {

app/assets/javascripts/environments/components/environments_table.js

@@ -73,15 +73,15 @@ export default {
               </td>
             </tr>
 
-            <tr v-if="!isLoadingFolderContent"
-              is="environment-item"
+            <template v-else>
+              <tr is="environment-item"
                 v-for="children in model.children"
                 :model="children"
                 :can-create-deployment="canCreateDeployment"
                 :can-read-environment="canReadEnvironment"
                 :service="service"></tr>
 
-            <tr v-if="!isLoadingFolderContent">
+              <tr>
                 <td colspan="6" class="text-center">
                   <a :href="folderUrl(model)" class="btn btn-default">
                     Show all
@@ -89,7 +89,7 @@ export default {
                 </td>
               </tr>
             </template>
-
+          </template>
         </template>
       </tbody>
     </table>

app/assets/javascripts/environments/services/environments_service.js

@@ -7,6 +7,7 @@ Vue.use(VueResource);
 export default class EnvironmentsService {
   constructor(endpoint) {
     this.environments = Vue.resource(endpoint);
+    this.folderResults = 3;
   }
 
   get(scope, page) {
@@ -18,7 +19,6 @@ export default class EnvironmentsService {
   }
 
   getFolderContent(folderUrl) {
-    const results = 3;
-    return Vue.http.get(`${folderUrl}.json?per_page=${results}`);
+    return Vue.http.get(`${folderUrl}.json?per_page=${this.folderResults}`);
   }
 }