Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
637df35f
Commit
637df35f
authored
Oct 05, 2018
by
Ramya Authappan
Committed by
Grzegorz Bizon
Oct 05, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adding qa-selectors for e2e tests
parent
ce2207b7
Changes
8
Show whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
58 additions
and
9 deletions
+58
-9
app/assets/javascripts/issue_show/components/edit_actions.vue
...assets/javascripts/issue_show/components/edit_actions.vue
+2
-2
app/assets/javascripts/issue_show/components/fields/description.vue
.../javascripts/issue_show/components/fields/description.vue
+2
-1
app/assets/javascripts/issue_show/components/fields/title.vue
...assets/javascripts/issue_show/components/fields/title.vue
+1
-1
app/assets/javascripts/issue_show/components/title.vue
app/assets/javascripts/issue_show/components/title.vue
+2
-1
app/assets/javascripts/notes/components/comment_form.vue
app/assets/javascripts/notes/components/comment_form.vue
+11
-4
qa/qa.rb
qa/qa.rb
+3
-0
qa/qa/page/component/issuable/common.rb
qa/qa/page/component/issuable/common.rb
+35
-0
qa/qa/page/project/issue/show.rb
qa/qa/page/project/issue/show.rb
+2
-0
No files found.
app/assets/javascripts/issue_show/components/edit_actions.vue
View file @
637df35f
...
...
@@ -66,7 +66,7 @@
<button
:class=
"
{ disabled: formState.updateLoading || !isSubmitEnabled }"
:disabled="formState.updateLoading || !isSubmitEnabled"
class="btn btn-success float-left"
class="btn btn-success float-left
qa-save-button
"
type="submit"
@click.prevent="updateIssuable">
Save changes
...
...
@@ -86,7 +86,7 @@
v-if=
"shouldShowDeleteButton"
:class=
"
{ disabled: deleteLoading }"
:disabled="deleteLoading"
class="btn btn-danger float-right append-right-default"
class="btn btn-danger float-right append-right-default
qa-delete-button
"
type="button"
@click="deleteIssuable">
Delete
...
...
app/assets/javascripts/issue_show/components/fields/description.vue
View file @
637df35f
...
...
@@ -61,7 +61,8 @@
ref=
"textarea"
slot=
"textarea"
v-model=
"formState.description"
class=
"note-textarea js-gfm-input js-autosize markdown-area"
class=
"note-textarea js-gfm-input js-autosize markdown-area
qa-description-textarea"
data-supports-quick-actions=
"false"
aria-label=
"Description"
placeholder=
"Write a comment or drag your files here…"
...
...
app/assets/javascripts/issue_show/components/fields/title.vue
View file @
637df35f
...
...
@@ -22,7 +22,7 @@
<input
id=
"issuable-title"
v-model=
"formState.title"
class=
"form-control"
class=
"form-control
qa-title-input
"
type=
"text"
placeholder=
"Title"
aria-label=
"Title"
...
...
app/assets/javascripts/issue_show/components/title.vue
View file @
637df35f
...
...
@@ -79,7 +79,8 @@ export default {
v-if=
"showInlineEditButton && canUpdate"
v-tooltip
type=
"button"
class=
"btn btn-default btn-edit btn-svg js-issuable-edit"
class=
"btn btn-default btn-edit btn-svg js-issuable-edit
qa-edit-button"
title=
"Edit title and description"
data-placement=
"bottom"
data-container=
"body"
...
...
app/assets/javascripts/notes/components/comment_form.vue
View file @
637df35f
...
...
@@ -7,7 +7,11 @@ import { __, sprintf } from '~/locale';
import
Flash
from
'
../../flash
'
;
import
Autosave
from
'
../../autosave
'
;
import
TaskList
from
'
../../task_list
'
;
import
{
capitalizeFirstCharacter
,
convertToCamelCase
,
splitCamelCase
}
from
'
../../lib/utils/text_utility
'
;
import
{
capitalizeFirstCharacter
,
convertToCamelCase
,
splitCamelCase
,
}
from
'
../../lib/utils/text_utility
'
;
import
*
as
constants
from
'
../constants
'
;
import
eventHub
from
'
../event_hub
'
;
import
issueWarning
from
'
../../vue_shared/components/issue/issue_warning.vue
'
;
...
...
@@ -122,7 +126,9 @@ export default {
return
this
.
getNoteableData
.
create_note_path
;
},
issuableTypeTitle
()
{
return
this
.
noteableType
===
constants
.
MERGE_REQUEST_NOTEABLE_TYPE
?
'
merge request
'
:
'
issue
'
;
return
this
.
noteableType
===
constants
.
MERGE_REQUEST_NOTEABLE_TYPE
?
'
merge request
'
:
'
issue
'
;
},
},
watch
:
{
...
...
@@ -359,7 +365,7 @@ Please check your network connection and try again.`;
:disabled=
"isSubmitting"
name=
"note[note]"
class=
"note-textarea js-vue-comment-form js-note-text
js-gfm-input js-autosize markdown-area js-vue-textarea"
js-gfm-input js-autosize markdown-area js-vue-textarea
qa-comment-input
"
data-supports-quick-actions=
"true"
aria-label=
"Description"
placeholder=
"Write a comment or drag your files here…"
...
...
@@ -374,7 +380,8 @@ js-gfm-input js-autosize markdown-area js-vue-textarea"
append-right-10 comment-type-dropdown js-comment-type-dropdown droplab-dropdown"
>
<button
:disabled=
"isSubmitButtonDisabled"
class=
"btn btn-success comment-btn js-comment-button js-comment-submit-button"
class=
"btn btn-create comment-btn js-comment-button js-comment-submit-button
qa-comment-button"
type=
"submit"
@
click.prevent=
"handleSave()"
>
{{
__
(
commentButtonTitle
)
}}
...
...
qa/qa.rb
View file @
637df35f
...
...
@@ -257,6 +257,9 @@ module QA
autoload
:Dropzone
,
'qa/page/component/dropzone'
autoload
:GroupsFilter
,
'qa/page/component/groups_filter'
autoload
:Select2
,
'qa/page/component/select2'
module
Issuable
autoload
:Common
,
'qa/page/component/issuable/common'
end
end
end
...
...
qa/qa/page/component/issuable/common.rb
0 → 100644
View file @
637df35f
# frozen_string_literal: true
module
QA
module
Page
module
Component
module
Issuable
module
Common
def
self
.
included
(
base
)
base
.
view
'app/assets/javascripts/issue_show/components/title.vue'
do
element
:edit_button
end
base
.
view
'app/assets/javascripts/issue_show/components/fields/title.vue'
do
element
:title_input
end
base
.
view
'app/assets/javascripts/issue_show/components/fields/description.vue'
do
element
:description_textarea
end
base
.
view
'app/assets/javascripts/issue_show/components/edit_actions.vue'
do
element
:save_button
element
:delete_button
end
base
.
view
'app/assets/javascripts/issue_show/components/edit_actions.vue'
do
element
:save_button
element
:delete_button
end
end
end
end
end
end
end
qa/qa/page/project/issue/show.rb
View file @
637df35f
...
...
@@ -5,6 +5,8 @@ module QA
module
Project
module
Issue
class
Show
<
Page
::
Base
include
Page
::
Component
::
Issuable
::
Common
view
'app/views/projects/issues/show.html.haml'
do
element
:issue_details
,
'.issue-details'
element
:title
,
'.title'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment