Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
651c3e84
Commit
651c3e84
authored
Apr 15, 2016
by
Yorick Peterse
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Instrument Repository.clean_old_archives
parent
c3f601e8
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
30 additions
and
4 deletions
+30
-4
CHANGELOG
CHANGELOG
+1
-0
app/models/repository.rb
app/models/repository.rb
+5
-3
spec/models/repository_spec.rb
spec/models/repository_spec.rb
+24
-1
No files found.
CHANGELOG
View file @
651c3e84
...
@@ -2,6 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date.
...
@@ -2,6 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date.
v 8.7.0 (unreleased)
v 8.7.0 (unreleased)
- Method instrumentation now uses Module#prepend instead of aliasing methods
- Method instrumentation now uses Module#prepend instead of aliasing methods
- Repository.clean_old_archives is now instrumented
- The Projects::HousekeepingService class has extra instrumentation
- The Projects::HousekeepingService class has extra instrumentation
- All service classes (those residing in app/services) are now instrumented
- All service classes (those residing in app/services) are now instrumented
- Developers can now add custom tags to transactions
- Developers can now add custom tags to transactions
...
...
app/models/repository.rb
View file @
651c3e84
...
@@ -12,12 +12,14 @@ class Repository
...
@@ -12,12 +12,14 @@ class Repository
attr_accessor
:path_with_namespace
,
:project
attr_accessor
:path_with_namespace
,
:project
def
self
.
clean_old_archives
def
self
.
clean_old_archives
Gitlab
::
Metrics
.
measure
(
:clean_old_archives
)
do
repository_downloads_path
=
Gitlab
.
config
.
gitlab
.
repository_downloads_path
repository_downloads_path
=
Gitlab
.
config
.
gitlab
.
repository_downloads_path
return
unless
File
.
directory?
(
repository_downloads_path
)
return
unless
File
.
directory?
(
repository_downloads_path
)
Gitlab
::
Popen
.
popen
(
%W(find
#{
repository_downloads_path
}
-not -path
#{
repository_downloads_path
}
-mmin +120 -delete)
)
Gitlab
::
Popen
.
popen
(
%W(find
#{
repository_downloads_path
}
-not -path
#{
repository_downloads_path
}
-mmin +120 -delete)
)
end
end
end
def
initialize
(
path_with_namespace
,
project
)
def
initialize
(
path_with_namespace
,
project
)
@path_with_namespace
=
path_with_namespace
@path_with_namespace
=
path_with_namespace
...
...
spec/models/repository_spec.rb
View file @
651c3e84
...
@@ -910,9 +910,32 @@ describe Repository, models: true do
...
@@ -910,9 +910,32 @@ describe Repository, models: true do
end
end
end
end
describe
'.clean_old_archives'
do
let
(
:path
)
{
Gitlab
.
config
.
gitlab
.
repository_downloads_path
}
context
'when the downloads directory does not exist'
do
it
'does not remove any archives'
do
expect
(
File
).
to
receive
(
:directory?
).
with
(
path
).
and_return
(
false
)
expect
(
Gitlab
::
Popen
).
not_to
receive
(
:popen
)
described_class
.
clean_old_archives
end
end
context
'when the downloads directory exists'
do
it
'removes old archives'
do
expect
(
File
).
to
receive
(
:directory?
).
with
(
path
).
and_return
(
true
)
expect
(
Gitlab
::
Popen
).
to
receive
(
:popen
)
described_class
.
clean_old_archives
end
end
end
def
create_remote_branch
(
remote_name
,
branch_name
,
target
)
def
create_remote_branch
(
remote_name
,
branch_name
,
target
)
rugged
=
repository
.
rugged
rugged
=
repository
.
rugged
rugged
.
references
.
create
(
"refs/remotes/
#{
remote_name
}
/
#{
branch_name
}
"
,
target
)
rugged
.
references
.
create
(
"refs/remotes/
#{
remote_name
}
/
#{
branch_name
}
"
,
target
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment