Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
67e0082e
Commit
67e0082e
authored
Aug 20, 2018
by
Ben Bodenmiller
Committed by
Kamil Trzciński
Aug 20, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
clarify runners currently online text
parent
3c80adf5
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
8 additions
and
3 deletions
+8
-3
app/views/admin/runners/index.html.haml
app/views/admin/runners/index.html.haml
+1
-1
changelogs/unreleased/runners-online.yml
changelogs/unreleased/runners-online.yml
+5
-0
spec/features/admin/admin_runners_spec.rb
spec/features/admin/admin_runners_spec.rb
+2
-2
No files found.
app/views/admin/runners/index.html.haml
View file @
67e0082e
...
...
@@ -49,7 +49,7 @@
=
submit_tag
'Search'
,
class:
'btn'
.float-right.light
Runners
with last contact more than a minute ago
:
#{
@active_runners_cnt
}
Runners
currently online
:
#{
@active_runners_cnt
}
%br
...
...
changelogs/unreleased/runners-online.yml
0 → 100644
View file @
67e0082e
---
title
:
Clarify current runners online text
merge_request
:
21151
author
:
Ben Bodenmiller
type
:
other
spec/features/admin/admin_runners_spec.rb
View file @
67e0082e
...
...
@@ -20,7 +20,7 @@ describe "Admin Runners" do
it
'has all necessary texts'
do
expect
(
page
).
to
have_text
"Setup a shared Runner manually"
expect
(
page
).
to
have_text
"Runners
with last contact more than a minute ago
: 1"
expect
(
page
).
to
have_text
"Runners
currently online
: 1"
end
describe
'search'
do
...
...
@@ -55,7 +55,7 @@ describe "Admin Runners" do
it
'has all necessary texts including no runner message'
do
expect
(
page
).
to
have_text
"Setup a shared Runner manually"
expect
(
page
).
to
have_text
"Runners
with last contact more than a minute ago
: 0"
expect
(
page
).
to
have_text
"Runners
currently online
: 0"
expect
(
page
).
to
have_text
'No runners found'
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment