Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
705da921
Commit
705da921
authored
Aug 24, 2018
by
Winnie Hellmann
Committed by
Rémy Coutable
Aug 24, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Drop WIP from changelog command in Danger comment
parent
71ba763a
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
2 deletions
+4
-2
danger/changelog/Dangerfile
danger/changelog/Dangerfile
+4
-2
No files found.
danger/changelog/Dangerfile
View file @
705da921
...
@@ -53,9 +53,11 @@ end
...
@@ -53,9 +53,11 @@ end
changelog_needed
=
(
gitlab
.
mr_labels
&
NO_CHANGELOG_LABELS
).
empty?
changelog_needed
=
(
gitlab
.
mr_labels
&
NO_CHANGELOG_LABELS
).
empty?
changelog_found
=
git
.
added_files
.
find
{
|
path
|
path
=~
%r{
\A
(ee/)?(changelogs/unreleased)(-ee)?/}
}
changelog_found
=
git
.
added_files
.
find
{
|
path
|
path
=~
%r{
\A
(ee/)?(changelogs/unreleased)(-ee)?/}
}
mr_title
=
gitlab
.
mr_json
[
"title"
].
gsub
(
/^WIP: */
,
''
)
if
git
.
modified_files
.
include?
(
"CHANGELOG.md"
)
if
git
.
modified_files
.
include?
(
"CHANGELOG.md"
)
fail
"**CHANGELOG.md was edited.** Please remove the additions and create a CHANGELOG entry.
\n\n
"
+
fail
"**CHANGELOG.md was edited.** Please remove the additions and create a CHANGELOG entry.
\n\n
"
+
format
(
CREATE_CHANGELOG_MESSAGE
,
mr_iid:
gitlab
.
mr_json
[
"iid"
],
mr_title:
gitlab
.
mr_json
[
"title"
]
,
labels:
presented_no_changelog_labels
)
format
(
CREATE_CHANGELOG_MESSAGE
,
mr_iid:
gitlab
.
mr_json
[
"iid"
],
mr_title:
mr_title
,
labels:
presented_no_changelog_labels
)
end
end
if
changelog_needed
if
changelog_needed
...
@@ -63,6 +65,6 @@ if changelog_needed
...
@@ -63,6 +65,6 @@ if changelog_needed
check_changelog
(
changelog_found
)
check_changelog
(
changelog_found
)
else
else
warn
"**[CHANGELOG missing](https://docs.gitlab.com/ce/development/changelog.html).**
\n\n
"
+
warn
"**[CHANGELOG missing](https://docs.gitlab.com/ce/development/changelog.html).**
\n\n
"
+
format
(
CREATE_CHANGELOG_MESSAGE
,
mr_iid:
gitlab
.
mr_json
[
"iid"
],
mr_title:
gitlab
.
mr_json
[
"title"
]
,
labels:
presented_no_changelog_labels
)
format
(
CREATE_CHANGELOG_MESSAGE
,
mr_iid:
gitlab
.
mr_json
[
"iid"
],
mr_title:
mr_title
,
labels:
presented_no_changelog_labels
)
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment