Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
7ab6806f
Commit
7ab6806f
authored
Mar 18, 2018
by
Takuya Noguchi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
UX re-design branch items with flexbox
parent
f8171595
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
95 additions
and
72 deletions
+95
-72
app/assets/stylesheets/pages/branches.scss
app/assets/stylesheets/pages/branches.scss
+19
-2
app/views/projects/branches/_branch.html.haml
app/views/projects/branches/_branch.html.haml
+71
-70
changelogs/unreleased/44386-better-ux-for-long-name-branches.yml
...ogs/unreleased/44386-better-ux-for-long-name-branches.yml
+5
-0
No files found.
app/assets/stylesheets/pages/branches.scss
View file @
7ab6806f
.content-list
>
.branch-item
,
.branch-title
{
display
:
flex
;
align-items
:
center
;
}
.branch-info
{
flex
:
auto
;
min-width
:
0
;
overflow
:
hidden
;
}
.divergence-graph
{
.divergence-graph
{
padding
:
12px
12px
0
0
;
padding
:
0
6px
;
float
:
right
;
.graph-side
{
.graph-side
{
position
:
relative
;
position
:
relative
;
...
@@ -53,3 +64,9 @@
...
@@ -53,3 +64,9 @@
background-color
:
$divergence-graph-separator-bg
;
background-color
:
$divergence-graph-separator-bg
;
}
}
}
}
.divergence-graph
,
.branch-item
.controls
{
flex
:
0
0
auto
;
white-space
:
nowrap
;
}
app/views/projects/branches/_branch.html.haml
View file @
7ab6806f
...
@@ -5,9 +5,10 @@
...
@@ -5,9 +5,10 @@
-
number_commits_behind
=
diverging_commit_counts
[
:behind
]
-
number_commits_behind
=
diverging_commit_counts
[
:behind
]
-
number_commits_ahead
=
diverging_commit_counts
[
:ahead
]
-
number_commits_ahead
=
diverging_commit_counts
[
:ahead
]
-
merge_project
=
can?
(
current_user
,
:create_merge_request
,
@project
)
?
@project
:
(
current_user
&&
current_user
.
fork_of
(
@project
))
-
merge_project
=
can?
(
current_user
,
:create_merge_request
,
@project
)
?
@project
:
(
current_user
&&
current_user
.
fork_of
(
@project
))
%li
{
class:
"js-branch-#{branch.name}"
}
%li
{
class:
"branch-item js-branch-#{branch.name}"
}
%div
.branch-info
=
link_to
project_tree_path
(
@project
,
branch
.
name
),
class:
'item-title str-truncated ref-name'
do
.branch-title
=
link_to
project_tree_path
(
@project
,
branch
.
name
),
class:
'item-title str-truncated-100 ref-name'
do
=
sprite_icon
(
'fork'
,
size:
12
)
=
sprite_icon
(
'fork'
,
size:
12
)
=
branch
.
name
=
branch
.
name
...
@@ -20,6 +21,25 @@
...
@@ -20,6 +21,25 @@
-
if
protected_branch?
(
@project
,
branch
)
-
if
protected_branch?
(
@project
,
branch
)
%span
.label.label-success
%span
.label.label-success
=
s_
(
'Branches|protected'
)
=
s_
(
'Branches|protected'
)
.block-truncated
-
if
commit
=
render
'projects/branches/commit'
,
commit:
commit
,
project:
@project
-
else
=
s_
(
'Branches|Cant find HEAD commit for this branch'
)
-
if
branch
.
name
!=
@repository
.
root_ref
.divergence-graph
{
title:
s_
(
'
%
{
number_commits_behind
}
commits
behind
%
{
default_branch
},
%
{
number_commits_ahead
}
commits
ahead
'
)
%
{
number_commits_behind:
diverging_count_label
(
number_commits_behind
),
default_branch:
@repository
.
root_ref
,
number_commits_ahead:
diverging_count_label
(
number_commits_ahead
)
}
}
.graph-side
.bar.bar-behind
{
style:
"width: #{number_commits_behind * bar_graph_width_factor}%"
}
%span
.count.count-behind
=
diverging_count_label
(
number_commits_behind
)
.graph-separator
.graph-side
.bar.bar-ahead
{
style:
"width: #{number_commits_ahead * bar_graph_width_factor}%"
}
%span
.count.count-ahead
=
diverging_count_label
(
number_commits_ahead
)
.controls.hidden-xs
<
.controls.hidden-xs
<
-
if
merge_project
&&
create_mr_button?
(
@repository
.
root_ref
,
branch
.
name
)
-
if
merge_project
&&
create_mr_button?
(
@repository
.
root_ref
,
branch
.
name
)
=
link_to
create_mr_path
(
@repository
.
root_ref
,
branch
.
name
),
class:
'btn btn-default'
do
=
link_to
create_mr_path
(
@repository
.
root_ref
,
branch
.
name
),
class:
'btn btn-default'
do
...
@@ -64,22 +84,3 @@
...
@@ -64,22 +84,3 @@
remote:
true
,
remote:
true
,
'aria-label'
=>
s_
(
'Branches|Delete branch'
)
do
'aria-label'
=>
s_
(
'Branches|Delete branch'
)
do
=
icon
(
"trash-o"
)
=
icon
(
"trash-o"
)
-
if
branch
.
name
!=
@repository
.
root_ref
.divergence-graph
{
title:
s_
(
'
%
{
number_commits_behind
}
commits
behind
%
{
default_branch
},
%
{
number_commits_ahead
}
commits
ahead
'
)
%
{
number_commits_behind:
diverging_count_label
(
number_commits_behind
),
default_branch:
@repository
.
root_ref
,
number_commits_ahead:
diverging_count_label
(
number_commits_ahead
)
}
}
.graph-side
.bar.bar-behind
{
style:
"width: #{number_commits_behind * bar_graph_width_factor}%"
}
%span
.count.count-behind
=
diverging_count_label
(
number_commits_behind
)
.graph-separator
.graph-side
.bar.bar-ahead
{
style:
"width: #{number_commits_ahead * bar_graph_width_factor}%"
}
%span
.count.count-ahead
=
diverging_count_label
(
number_commits_ahead
)
-
if
commit
=
render
'projects/branches/commit'
,
commit:
commit
,
project:
@project
-
else
%p
=
s_
(
'Branches|Cant find HEAD commit for this branch'
)
changelogs/unreleased/44386-better-ux-for-long-name-branches.yml
0 → 100644
View file @
7ab6806f
---
title
:
UX re-design branch items with flexbox
merge_request
:
17832
author
:
Takuya Noguchi
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment