Commit 8d571b14 authored by Jarka Kadlecova's avatar Jarka Kadlecova

Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce

parents 84a7c487 fa72d346
...@@ -8,6 +8,7 @@ class Repository ...@@ -8,6 +8,7 @@ class Repository
RESERVED_REFS_NAMES = %W[ RESERVED_REFS_NAMES = %W[
heads heads
tags tags
replace
#{REF_ENVIRONMENTS} #{REF_ENVIRONMENTS}
#{REF_KEEP_AROUND} #{REF_KEEP_AROUND}
#{REF_ENVIRONMENTS} #{REF_ENVIRONMENTS}
......
---
title: Adds gitlab features and components to usage ping data.
merge_request: 14305
author:
type: other
---
title: Fix `rake gitlab:incoming_email:check` and make it report the actual error
merge_request: 14423
author:
type: fixed
---
title: Also reserve refs/replace after importing a project
merge_request: 14436
author:
type: fixed
...@@ -9,12 +9,28 @@ module Gitlab ...@@ -9,12 +9,28 @@ module Gitlab
def uncached_data def uncached_data
license_usage_data.merge(system_usage_data) license_usage_data.merge(system_usage_data)
.merge(features_usage_data)
.merge(components_usage_data)
end end
def to_json(force_refresh: false) def to_json(force_refresh: false)
data(force_refresh: force_refresh).to_json data(force_refresh: force_refresh).to_json
end end
def license_usage_data
usage_data = {
uuid: current_application_settings.uuid,
hostname: Gitlab.config.gitlab.host,
version: Gitlab::VERSION,
active_user_count: User.active.count,
recorded_at: Time.now,
mattermost_enabled: Gitlab.config.mattermost.enabled,
edition: 'CE'
}
usage_data
end
def system_usage_data def system_usage_data
{ {
counts: { counts: {
...@@ -54,18 +70,28 @@ module Gitlab ...@@ -54,18 +70,28 @@ module Gitlab
} }
end end
def license_usage_data def features_usage_data
usage_data = { features_usage_data_ce
uuid: current_application_settings.uuid, end
hostname: Gitlab.config.gitlab.host,
version: Gitlab::VERSION, def features_usage_data_ce
active_user_count: User.active.count, {
recorded_at: Time.now, signup: current_application_settings.signup_enabled?,
mattermost_enabled: Gitlab.config.mattermost.enabled, ldap: Gitlab.config.ldap.enabled,
edition: 'CE' gravatar: current_application_settings.gravatar_enabled?,
omniauth: Gitlab.config.omniauth.enabled,
reply_by_email: Gitlab::IncomingEmail.enabled?,
container_registry: Gitlab.config.registry.enabled,
gitlab_shared_runners: Gitlab.config.gitlab_ci.shared_runners_enabled
} }
end
usage_data def components_usage_data
{
gitlab_pages: { enabled: Gitlab.config.pages.enabled, version: Gitlab::Pages::VERSION },
git: { version: Gitlab::Git.version },
database: { adapter: Gitlab::Database.adapter_name, version: Gitlab::Database.version }
}
end end
def services_usage def services_usage
......
...@@ -4,22 +4,17 @@ module SystemCheck ...@@ -4,22 +4,17 @@ module SystemCheck
set_name 'IMAP server credentials are correct?' set_name 'IMAP server credentials are correct?'
def check? def check?
if mailbox_config if config
begin try_connect_imap
imap = Net::IMAP.new(config[:host], port: config[:port], ssl: config[:ssl]) else
imap.starttls if config[:start_tls] @error = "#{mail_room_config_path} does not have mailboxes setup"
imap.login(config[:email], config[:password]) false
connected = true
rescue
connected = false
end end
end end
connected
end
def show_error def show_error
try_fixing_it( try_fixing_it(
"An error occurred: #{@error.class}: #{@error.message}",
'Check that the information in config/gitlab.yml is correct' 'Check that the information in config/gitlab.yml is correct'
) )
for_more_information( for_more_information(
...@@ -30,15 +25,31 @@ module SystemCheck ...@@ -30,15 +25,31 @@ module SystemCheck
private private
def mailbox_config def try_connect_imap
return @config if @config imap = Net::IMAP.new(config[:host], port: config[:port], ssl: config[:ssl])
imap.starttls if config[:start_tls]
imap.login(config[:email], config[:password])
true
rescue => error
@error = error
false
end
def config
@config ||= load_config
end
def mail_room_config_path
@mail_room_config_path ||=
Rails.root.join('config', 'mail_room.yml').to_s
end
config_path = Rails.root.join('config', 'mail_room.yml').to_s def load_config
erb = ERB.new(File.read(config_path)) erb = ERB.new(File.read(mail_room_config_path))
erb.filename = config_path erb.filename = mail_room_config_path
config_file = YAML.load(erb.result) config_file = YAML.load(erb.result)
@config = config_file[:mailboxes]&.first config_file.dig(:mailboxes, 0)
end end
end end
end end
......
...@@ -26,6 +26,16 @@ describe Gitlab::UsageData do ...@@ -26,6 +26,16 @@ describe Gitlab::UsageData do
version version
uuid uuid
hostname hostname
signup
ldap
gravatar
omniauth
reply_by_email
container_registry
gitlab_pages
gitlab_shared_runners
git
database
)) ))
end end
...@@ -86,6 +96,32 @@ describe Gitlab::UsageData do ...@@ -86,6 +96,32 @@ describe Gitlab::UsageData do
end end
end end
describe '#features_usage_data_ce' do
subject { described_class.features_usage_data_ce }
it 'gathers feature usage data' do
expect(subject[:signup]).to eq(current_application_settings.signup_enabled?)
expect(subject[:ldap]).to eq(Gitlab.config.ldap.enabled)
expect(subject[:gravatar]).to eq(current_application_settings.gravatar_enabled?)
expect(subject[:omniauth]).to eq(Gitlab.config.omniauth.enabled)
expect(subject[:reply_by_email]).to eq(Gitlab::IncomingEmail.enabled?)
expect(subject[:container_registry]).to eq(Gitlab.config.registry.enabled)
expect(subject[:gitlab_shared_runners]).to eq(Gitlab.config.gitlab_ci.shared_runners_enabled)
end
end
describe '#components_usage_data' do
subject { described_class.components_usage_data }
it 'gathers components usage data' do
expect(subject[:gitlab_pages][:enabled]).to eq(Gitlab.config.pages.enabled)
expect(subject[:gitlab_pages][:version]).to eq(Gitlab::Pages::VERSION)
expect(subject[:git][:version]).to eq(Gitlab::Git.version)
expect(subject[:database][:adapter]).to eq(Gitlab::Database.adapter_name)
expect(subject[:database][:version]).to eq(Gitlab::Database.version)
end
end
describe '#license_usage_data' do describe '#license_usage_data' do
subject { described_class.license_usage_data } subject { described_class.license_usage_data }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment