Merge branch 'security-master-guests-jobs-api' into 'master'

[master] Guest users have access to all Job information via the API

See merge request gitlab/gitlabhq!2717

changelogs/unreleased/security-master-guests-jobs-api.yml

+---
+title: Authorize before reading job information via API.
+merge_request:
+author:
+type: security

lib/api/jobs.rb

@@ -38,6 +38,8 @@ module API
       end
       # rubocop: disable CodeReuse/ActiveRecord
       get ':id/jobs' do
+        authorize_read_builds!
+
         builds = user_project.builds.order('id DESC')
         builds = filter_builds(builds, params[:scope])
 
@@ -56,7 +58,10 @@ module API
       end
       # rubocop: disable CodeReuse/ActiveRecord
       get ':id/pipelines/:pipeline_id/jobs' do
+        authorize!(:read_pipeline, user_project)
         pipeline = user_project.ci_pipelines.find(params[:pipeline_id])
+        authorize!(:read_build, pipeline)
+
         builds = pipeline.builds
         builds = filter_builds(builds, params[:scope])
         builds = builds.preload(:job_artifacts_archive, :job_artifacts, project: [:namespace])

spec/requests/api/jobs_spec.rb

@@ -142,6 +142,7 @@ describe API::Jobs do
     end
 
     context 'unauthorized user' do
+      context 'when user is not logged in' do
         let(:api_user) { nil }
 
         it 'does not return project jobs' do
@@ -149,6 +150,15 @@ describe API::Jobs do
         end
       end
 
+      context 'when user is guest' do
+        let(:api_user) { guest }
+
+        it 'does not return project jobs' do
+          expect(response).to have_gitlab_http_status(403)
+        end
+      end
+    end
+
     def go
       get api("/projects/#{project.id}/jobs", api_user), params: query
     end
@@ -241,12 +251,22 @@ describe API::Jobs do
     end
 
     context 'unauthorized user' do
+      context 'when user is not logged in' do
         let(:api_user) { nil }
 
         it 'does not return jobs' do
           expect(response).to have_gitlab_http_status(401)
         end
       end
+
+      context 'when user is guest' do
+        let(:api_user) { guest }
+
+        it 'does not return jobs' do
+          expect(response).to have_gitlab_http_status(403)
+        end
+      end
+    end
   end
 
   describe 'GET /projects/:id/jobs/:job_id' do