Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
a154d9db
Commit
a154d9db
authored
Jun 11, 2019
by
Sanad Liaquat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Comment will select all activites filter by default
parent
3efd59b9
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
4 additions
and
5 deletions
+4
-5
qa/qa/page/project/issue/show.rb
qa/qa/page/project/issue/show.rb
+2
-1
qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb
...ecs/features/browser_ui/2_plan/issue/create_issue_spec.rb
+0
-1
qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb
...res/browser_ui/2_plan/issue/filter_issue_comments_spec.rb
+2
-3
No files found.
qa/qa/page/project/issue/show.rb
View file @
a154d9db
...
...
@@ -29,7 +29,8 @@ module QA
# Adds a comment to an issue
# attachment option should be an absolute path
def
comment
(
text
,
attachment:
nil
)
def
comment
(
text
,
attachment:
nil
,
filter: :all_activities
)
method
(
"select_
#{
filter
}
_filter"
).
call
fill_element
:comment_input
,
text
unless
attachment
.
nil?
...
...
qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb
View file @
a154d9db
...
...
@@ -23,7 +23,6 @@ module QA
create_issue
Page
::
Project
::
Issue
::
Show
.
perform
do
|
show
|
show
.
select_all_activities_filter
show
.
comment
(
'See attached banana for scale'
,
attachment:
file_to_attach
)
show
.
refresh
...
...
qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb
View file @
a154d9db
...
...
@@ -16,9 +16,8 @@ module QA
expect
(
page
).
to
have_content
(
issue_title
)
Page
::
Project
::
Issue
::
Show
.
perform
do
|
show_page
|
show_page
.
select_comments_only_filter
show_page
.
comment
(
'/confidential'
)
show_page
.
comment
(
'My own comment'
)
show_page
.
comment
(
'/confidential'
,
filter: :comments_only
)
show_page
.
comment
(
'My own comment'
,
filter: :comments_only
)
expect
(
show_page
).
not_to
have_content
(
"made the issue confidential"
)
expect
(
show_page
).
to
have_content
(
"My own comment"
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment