Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
a4a29e2e
Commit
a4a29e2e
authored
Mar 12, 2018
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add TODOs to refactoried variables collections code
parent
b94db067
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
0 deletions
+5
-0
lib/gitlab/ci/variables/collection.rb
lib/gitlab/ci/variables/collection.rb
+1
-0
lib/gitlab/ci/variables/collection/item.rb
lib/gitlab/ci/variables/collection/item.rb
+4
-0
No files found.
lib/gitlab/ci/variables/collection.rb
View file @
a4a29e2e
...
@@ -14,6 +14,7 @@ module Gitlab
...
@@ -14,6 +14,7 @@ module Gitlab
@variables
.
append
(
Collection
::
Item
.
fabricate
(
resource
))
@variables
.
append
(
Collection
::
Item
.
fabricate
(
resource
))
end
end
# TODO, specs
def
concat
(
resources
)
def
concat
(
resources
)
resources
.
each
{
|
variable
|
self
.
append
(
variable
)
}
resources
.
each
{
|
variable
|
self
.
append
(
variable
)
}
end
end
...
...
lib/gitlab/ci/variables/collection/item.rb
View file @
a4a29e2e
...
@@ -3,6 +3,8 @@ module Gitlab
...
@@ -3,6 +3,8 @@ module Gitlab
module
Variables
module
Variables
class
Collection
class
Collection
class
Item
class
Item
# TODO, public by default?
#
def
initialize
(
**
options
)
def
initialize
(
**
options
)
@variable
=
{
@variable
=
{
key:
options
.
fetch
(
:key
),
key:
options
.
fetch
(
:key
),
...
@@ -28,6 +30,8 @@ module Gitlab
...
@@ -28,6 +30,8 @@ module Gitlab
end
end
def
self
.
fabricate
(
resource
)
def
self
.
fabricate
(
resource
)
# TODO, to_runner_variable by default for class < ActiveRecord::Base
#
case
resource
case
resource
when
Hash
when
Hash
self
.
new
(
resource
)
self
.
new
(
resource
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment