Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
b359d5d5
Commit
b359d5d5
authored
May 24, 2016
by
Stan Hu
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix groups API to list only user's accessible projects
Closes #17496
parent
d6e5299f
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
21 additions
and
6 deletions
+21
-6
CHANGELOG
CHANGELOG
+1
-0
app/finders/group_projects_finder.rb
app/finders/group_projects_finder.rb
+1
-1
lib/api/groups.rb
lib/api/groups.rb
+1
-2
spec/requests/api/groups_spec.rb
spec/requests/api/groups_spec.rb
+18
-3
No files found.
CHANGELOG
View file @
b359d5d5
...
...
@@ -2,6 +2,7 @@ Please view this file on the master branch, on stable branches it's out of date.
v 8.9.0 (unreleased)
- Redesign navigation for project pages
- Fix groups API to list only user's accessible projects
- Use gitlab-shell v3.0.0
v 8.8.2 (unreleased)
...
...
app/finders/group_projects_finder.rb
View file @
b359d5d5
...
...
@@ -18,7 +18,7 @@ class GroupProjectsFinder < UnionFinder
projects
=
[]
if
current_user
if
@group
.
users
.
include?
(
current_user
)
if
@group
.
users
.
include?
(
current_user
)
||
current_user
.
admin?
projects
<<
@group
.
projects
unless
only_shared
projects
<<
@group
.
shared_projects
unless
only_owned
else
...
...
lib/api/groups.rb
View file @
b359d5d5
...
...
@@ -95,8 +95,7 @@ module API
# GET /groups/:id/projects
get
":id/projects"
do
group
=
find_group
(
params
[
:id
])
projects
=
group
.
projects
projects
=
filter_projects
(
projects
)
projects
=
GroupProjectsFinder
.
new
(
group
).
execute
(
current_user
)
projects
=
paginate
projects
present
projects
,
with:
Entities
::
Project
end
...
...
spec/requests/api/groups_spec.rb
View file @
b359d5d5
...
...
@@ -12,6 +12,7 @@ describe API::API, api: true do
let!
(
:group2
)
{
create
(
:group
,
:private
)
}
let!
(
:project1
)
{
create
(
:project
,
namespace:
group1
)
}
let!
(
:project2
)
{
create
(
:project
,
namespace:
group2
)
}
let!
(
:project3
)
{
create
(
:project
,
namespace:
group1
,
path:
'test'
,
visibility_level:
Gitlab
::
VisibilityLevel
::
PRIVATE
)
}
before
do
group1
.
add_owner
(
user1
)
...
...
@@ -147,9 +148,11 @@ describe API::API, api: true do
context
"when authenticated as user"
do
it
"should return the group's projects"
do
get
api
(
"/groups/
#{
group1
.
id
}
/projects"
,
user1
)
expect
(
response
.
status
).
to
eq
(
200
)
expect
(
json_response
.
length
).
to
eq
(
1
)
expect
(
json_response
.
first
[
'name'
]).
to
eq
(
project1
.
name
)
expect
(
json_response
.
length
).
to
eq
(
2
)
project_names
=
json_response
.
map
{
|
proj
|
proj
[
'name'
]
}
expect
(
project_names
).
to
match_array
([
project1
.
name
,
project3
.
name
])
end
it
"should not return a non existing group"
do
...
...
@@ -162,6 +165,16 @@ describe API::API, api: true do
expect
(
response
.
status
).
to
eq
(
404
)
end
it
"should only return projects to which user has access"
do
project3
.
team
<<
[
user3
,
:developer
]
get
api
(
"/groups/
#{
group1
.
id
}
/projects"
,
user3
)
expect
(
response
.
status
).
to
eq
(
200
)
expect
(
json_response
.
length
).
to
eq
(
1
)
expect
(
json_response
.
first
[
'name'
]).
to
eq
(
project3
.
name
)
end
end
context
"when authenticated as admin"
do
...
...
@@ -181,8 +194,10 @@ describe API::API, api: true do
context
'when using group path in URL'
do
it
'should return any existing group'
do
get
api
(
"/groups/
#{
group1
.
path
}
/projects"
,
admin
)
expect
(
response
.
status
).
to
eq
(
200
)
expect
(
json_response
.
first
[
'name'
]).
to
eq
(
project1
.
name
)
project_names
=
json_response
.
map
{
|
proj
|
proj
[
'name'
]
}
expect
(
project_names
).
to
match_array
([
project1
.
name
,
project3
.
name
])
end
it
'should not return a non existing group'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment