Separate conditions to increase readability

b5b56588 · Patrick Derichs · 932a9a0c · b5b56588
Commit b5b56588 authored Jun 15, 2019 by Patrick Derichs
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

app/finders/notes_finder.rb app/finders/notes_finder.rb +2 -1

No files found.
--- a/app/finders/notes_finder.rb
+++ b/app/finders/notes_finder.rb
@@ -36,7 +36,8 @@ class NotesFinder
    target_id   = @params[:target_id]
    target_iid  = @params[:target_iid]

-    return @target = nil unless target_type && (target_id || target_iid)
+    return @target = nil unless target_type
+    return @target = nil unless (target_id || target_iid)

    @target =
      if target_type == "commit"