Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
b9dde18a
Commit
b9dde18a
authored
Sep 20, 2018
by
Mark Lapierre
Committed by
Robert Speicher
Sep 20, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
QA: Fix failure in merge_merge_request_from_fork_spec.rb
parent
89985b9f
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
5 deletions
+21
-5
app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue
...merge_request_widget/components/states/ready_to_merge.vue
+3
-3
qa/qa/page/merge_request/show.rb
qa/qa/page/merge_request/show.rb
+18
-2
No files found.
app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue
View file @
b9dde18a
...
...
@@ -255,7 +255,7 @@ export default {
data-toggle=
"dropdown"
aria-label=
"Select merge moment"
>
<i
class=
"fa fa-chevron-down"
class=
"fa fa-chevron-down
qa-merge-moment-dropdown
"
aria-hidden=
"true"
></i>
</button>
...
...
@@ -265,7 +265,7 @@ export default {
role=
"menu"
>
<li>
<a
class=
"merge_when_pipeline_succeeds"
class=
"merge_when_pipeline_succeeds
qa-merge-when-pipeline-succeeds-option
"
href=
"#"
@
click.prevent=
"handleMergeButtonClick(true)"
>
<span
class=
"media"
>
...
...
@@ -279,7 +279,7 @@ export default {
</li>
<li>
<a
class=
"accept-merge-request"
class=
"accept-merge-request
qa-merge-immediately-option
"
href=
"#"
@
click.prevent=
"handleMergeButtonClick(false, true)"
>
<span
class=
"media"
>
...
...
qa/qa/page/merge_request/show.rb
View file @
b9dde18a
...
...
@@ -5,6 +5,9 @@ module QA
view
'app/assets/javascripts/vue_merge_request_widget/components/states/ready_to_merge.vue'
do
element
:merge_button
element
:fast_forward_message
,
'Fast-forward merge without a merge commit'
element
:merge_moment_dropdown
element
:merge_when_pipeline_succeeds_option
element
:merge_immediately_option
end
view
'app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_merged.vue'
do
...
...
@@ -27,7 +30,20 @@ module QA
def
has_merge_button?
refresh
has_selector?
(
'.accept-merge-request'
)
has_css?
(
element_selector_css
(
:merge_button
))
end
def
has_merge_options?
has_css?
(
element_selector_css
(
:merge_moment_dropdown
))
end
def
merge_immediately
if
has_merge_options?
click_element
:merge_moment_dropdown
click_element
:merge_immediately_option
else
click_element
:merge_button
end
end
def
rebase!
...
...
@@ -59,7 +75,7 @@ module QA
!
first
(
element_selector_css
(
:merge_button
)).
disabled?
end
click_element
:merge_button
merge_immediately
wait
(
reload:
false
)
do
has_text?
(
'The changes were merged into'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment