Changes after review

app/assets/javascripts/pipelines/components/pipelines_table.vue

@@ -23,7 +23,7 @@
       },
       viewType: {
         type: String,
-        required: false,
+        required: true,
       },
     },
     components: {

app/assets/javascripts/pipelines/components/pipelines_table_row.vue

@@ -31,7 +31,7 @@ export default {
     },
     viewType: {
       type: String,
-      required: false,
+      required: true,
     },
   },
   components: {

app/assets/javascripts/vue_shared/components/ci_badge_link.vue

@@ -54,7 +54,7 @@
     :href="status.details_path"
     :class="cssClass"
     v-tooltip
-    :title="status.text">
+    :title="!showText ? status.text : ''">
     <ci-icon :status="status" />
 
     <template v-if="showText">

spec/javascripts/pipelines/pipelines_table_row_spec.js

@@ -10,6 +10,7 @@ describe('Pipelines Table Row', () => {
       propsData: {
         pipeline,
         autoDevopsHelpPath: 'foo',
+        viewType: 'root',
       },
     }).$mount();
   };

spec/javascripts/pipelines/pipelines_table_spec.js

@@ -23,6 +23,7 @@ describe('Pipelines Table', () => {
         propsData: {
           pipelines: [],
           autoDevopsHelpPath: 'foo',
+          viewType: 'root',
         },
       }).$mount();
     });
@@ -49,6 +50,7 @@ describe('Pipelines Table', () => {
         propsData: {
           pipelines: [],
           autoDevopsHelpPath: 'foo',
+          viewType: 'root',
         },
       }).$mount();
       expect(component.$el.querySelectorAll('.commit.gl-responsive-table-row').length).toEqual(0);
@@ -61,6 +63,7 @@ describe('Pipelines Table', () => {
         propsData: {
           pipelines: [pipeline],
           autoDevopsHelpPath: 'foo',
+          viewType: 'root',
         },
       }).$mount();