Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
cbeab67a
Commit
cbeab67a
authored
Feb 21, 2019
by
Marcia Ramos
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply suggestion to doc/development/code_review.md
parent
6349a185
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
doc/development/code_review.md
doc/development/code_review.md
+1
-1
No files found.
doc/development/code_review.md
View file @
cbeab67a
...
@@ -205,7 +205,7 @@ first time.
...
@@ -205,7 +205,7 @@ first time.
-
Try to respond to every comment.
-
Try to respond to every comment.
-
The merge request author resolves only the discussions they have fully
-
The merge request author resolves only the discussions they have fully
addressed. If there's an open reply, an open discussion, a suggestion,
addressed. If there's an open reply, an open discussion, a suggestion,
a question, or anything else, the discussion
must
be left to be resolved
a question, or anything else, the discussion
should
be left to be resolved
by the reviewer.
by the reviewer.
-
Push commits based on earlier rounds of feedback as isolated commits to the
-
Push commits based on earlier rounds of feedback as isolated commits to the
branch. Do not squash until the branch is ready to merge. Reviewers should be
branch. Do not squash until the branch is ready to merge. Reviewers should be
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment