add a comment warning that note.project may be nil

e4789cdf · http://jneen.net/ · 273cd9c3 · e4789cdf
Commit e4789cdf authored Aug 02, 2017 by http://jneen.net/
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

app/services/notification_recipient_service.rb app/services/notification_recipient_service.rb +4 -0

No files found.
--- a/app/services/notification_recipient_service.rb
+++ b/app/services/notification_recipient_service.rb
@@ -252,6 +252,10 @@ module NotificationRecipientService
        note.noteable
      end
+      # NOTE: may be nil, in the case of a PersonalSnippet
+      #
+      # (this is okay because NotificationRecipient is written
+      # to handle nil projects)
      def project
        note.project
      end