Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
f1955962
Commit
f1955962
authored
Jun 15, 2018
by
Jasper Maes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Rails5 fix update_attribute usage not causing a save
parent
fb08183e
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
4 deletions
+9
-4
changelogs/unreleased/rails5-fix-47960.yml
changelogs/unreleased/rails5-fix-47960.yml
+5
-0
spec/controllers/projects/imports_controller_spec.rb
spec/controllers/projects/imports_controller_spec.rb
+4
-4
No files found.
changelogs/unreleased/rails5-fix-47960.yml
0 → 100644
View file @
f1955962
---
title
:
Rails5 fix update_attribute usage not causing a save
merge_request
:
19881
author
:
Jasper Maes
type
:
fixed
spec/controllers/projects/imports_controller_spec.rb
View file @
f1955962
...
@@ -29,7 +29,7 @@ describe Projects::ImportsController do
...
@@ -29,7 +29,7 @@ describe Projects::ImportsController do
context
'when import is in progress'
do
context
'when import is in progress'
do
before
do
before
do
project
.
update_attribute
(
:import_status
,
:started
)
project
.
update_attribute
s
(
import_status:
:started
)
end
end
it
'renders template'
do
it
'renders template'
do
...
@@ -47,7 +47,7 @@ describe Projects::ImportsController do
...
@@ -47,7 +47,7 @@ describe Projects::ImportsController do
context
'when import failed'
do
context
'when import failed'
do
before
do
before
do
project
.
update_attribute
(
:import_status
,
:failed
)
project
.
update_attribute
s
(
import_status:
:failed
)
end
end
it
'redirects to new_namespace_project_import_path'
do
it
'redirects to new_namespace_project_import_path'
do
...
@@ -59,7 +59,7 @@ describe Projects::ImportsController do
...
@@ -59,7 +59,7 @@ describe Projects::ImportsController do
context
'when import finished'
do
context
'when import finished'
do
before
do
before
do
project
.
update_attribute
(
:import_status
,
:finished
)
project
.
update_attribute
s
(
import_status:
:finished
)
end
end
context
'when project is a fork'
do
context
'when project is a fork'
do
...
@@ -108,7 +108,7 @@ describe Projects::ImportsController do
...
@@ -108,7 +108,7 @@ describe Projects::ImportsController do
context
'when import never happened'
do
context
'when import never happened'
do
before
do
before
do
project
.
update_attribute
(
:import_status
,
:none
)
project
.
update_attribute
s
(
import_status:
:none
)
end
end
it
'redirects to namespace_project_path'
do
it
'redirects to namespace_project_path'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment