Commit fd4fd25d authored by Grzegorz Bizon's avatar Grzegorz Bizon

Fix passing a hash with string keys when fabricating a variable

parent 3779d76d
...@@ -34,7 +34,7 @@ module Gitlab ...@@ -34,7 +34,7 @@ module Gitlab
def self.fabricate(resource) def self.fabricate(resource)
case resource case resource
when Hash when Hash
self.new(resource) self.new(resource.symbolize_keys)
when ::HasVariable when ::HasVariable
self.new(resource.to_runner_variable) self.new(resource.to_runner_variable)
when self when self
......
...@@ -75,6 +75,14 @@ describe Gitlab::Ci::Variables::Collection::Item do ...@@ -75,6 +75,14 @@ describe Gitlab::Ci::Variables::Collection::Item do
expect(resource).to eq variable expect(resource).to eq variable
end end
it 'supports using a hash with stringified values' do
variable = { 'key' => 'VARIABLE', 'value' => 'my value' }
resource = described_class.fabricate(variable)
expect(resource).to eq(key: 'VARIABLE', value: 'my value')
end
it 'supports using an active record resource' do it 'supports using an active record resource' do
variable = create(:ci_variable, key: 'CI_VAR', value: '123') variable = create(:ci_variable, key: 'CI_VAR', value: '123')
resource = described_class.fabricate(variable) resource = described_class.fabricate(variable)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment