diff --git a/bt5/erp5_hal_json_style/TestTemplateItem/portal_components/test.erp5.testHalJsonStyle.py b/bt5/erp5_hal_json_style/TestTemplateItem/portal_components/test.erp5.testHalJsonStyle.py index f2f118d839ddbd8be380f8ec85c73542b2049e39..d2491dca0be9e5013a5c64e20c6562f1b9edf2de 100644 --- a/bt5/erp5_hal_json_style/TestTemplateItem/portal_components/test.erp5.testHalJsonStyle.py +++ b/bt5/erp5_hal_json_style/TestTemplateItem/portal_components/test.erp5.testHalJsonStyle.py @@ -16,7 +16,7 @@ import json import re import urllib -from zope.globalrequest import setRequest +from zope.globalrequest import setRequest # pylint: disable=no-name-in-module, import-error from Acquisition import aq_base from Products.ERP5Form.Selection import Selection, DomainSelection diff --git a/bt5/erp5_hal_json_style/bt/skip_coding_style_test b/bt5/erp5_hal_json_style/bt/skip_coding_style_test deleted file mode 100644 index 56a6051ca2b02b04ef92d5150c9ef600403cb1de..0000000000000000000000000000000000000000 --- a/bt5/erp5_hal_json_style/bt/skip_coding_style_test +++ /dev/null @@ -1 +0,0 @@ -1 \ No newline at end of file diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/AccessTabZuite_setPreference.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/AccessTabZuite_setPreference.py index aa4ec474efb94b1852a37f080557d827c167a480..b21cf56140e6d19a7af60bd9813fc211e9ed8406 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/AccessTabZuite_setPreference.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/AccessTabZuite_setPreference.py @@ -7,6 +7,6 @@ if preference is None: portal_type="Preference") if preference.getPreferenceState() != "enabled": - preference.enable() + preference.enable() return 'Set Preference Successfully.' diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Base_directWorkflowAction.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Base_directWorkflowAction.py index 567566d10a0ccb0471ae0be009bb1cd20771174b..3a99ceadf76b396495339bde58fb41fb76dd98bc 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Base_directWorkflowAction.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Base_directWorkflowAction.py @@ -1,4 +1,3 @@ -request = context.REQUEST context.portal_workflow.doActionFor(context , workflow_action, comment='', **kw) message = 'direct workflow action done.' return context.Base_redirect('view', keep_items={'portal_status_message': message}) diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_checkFormBoxDialog.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_checkFormBoxDialog.py index 643cadb979b4e2296ed88a12cac812992fdb5b31..10e4a45dec0de934bc8ca913026feded549f850b 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_checkFormBoxDialog.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_checkFormBoxDialog.py @@ -1,3 +1,5 @@ +# this script has a parameter named `id` +# pylint: disable=redefined-builtin """Redirect to Foo_viewFormBox""" msg = "%s %s %s %s" % (id, title, quantity, description) diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_getListBoxInReportModeSectionList.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_getListBoxInReportModeSectionList.py index e833371e58f58ba7a843d91aaf21eae51d57293e..9e272f1ad015ae7743f79f2ebc4a029bb854d425 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_getListBoxInReportModeSectionList.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/Foo_getListBoxInReportModeSectionList.py @@ -8,4 +8,4 @@ kw = { # 'selection_params': {}, 'temporary_selection': False, } -return [ReportSection(**kw) for x in xrange(3)] +return [ReportSection(**kw) for _ in xrange(3)] diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxDialogModeZuite_reset.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxDialogModeZuite_reset.py index 8a43bc53eda833568ea0d506d64ab76357a4388c..b062cad3759f2adbaa28b2762d7d375140abc364 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxDialogModeZuite_reset.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxDialogModeZuite_reset.py @@ -13,7 +13,7 @@ default_columns = '\n'.join(( 'id | ID' , 'title | Title' , 'quantity | Quantity' )) -result = form.listbox.ListBox_setPropertyList( +form.listbox.ListBox_setPropertyList( field_title = 'Bars' , field_columns = default_columns , field_sort = 'id' diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxZuite_reset.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxZuite_reset.py index eada76e1cd796cafd09351fd60f933268bfc1e4c..5503f312c144c5b9fe99f04d1eb63ed21d6de975 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxZuite_reset.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/ListBoxZuite_reset.py @@ -8,7 +8,7 @@ for name in ('foo_module', 'bar_module', 'foo_bar_module'): # Reset the foo module listbox form = context.FooModule_viewFooList -result = form.listbox.ListBox_setPropertyList() +form.listbox.ListBox_setPropertyList() #form.listbox.manage_edit(dict( # lines = 3, all_columns = [], search_columns = [], sort_columns = [], @@ -22,7 +22,7 @@ default_columns = '\n'.join(( 'id | ID' , 'title | Title' , 'quantity | Quantity' )) -result = form.listbox.ListBox_setPropertyList( +form.listbox.ListBox_setPropertyList( field_title = 'Foo Lines' , field_columns = default_columns , field_sort = 'id' diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_addAction.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_addAction.py index 6133b3f25bf28b7f8c45bce039b032fd15149735..9f18f9bcc12c3957a034a3d7f60a86c2d84a12eb 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_addAction.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_addAction.py @@ -1,3 +1,5 @@ +# this script has a parameter named `id` +# pylint: disable=redefined-builtin """Add or replace an action on a type informations from types tool. """ assert context.meta_type in ('ERP5 Type Information', 'ERP5 Base Type'), context.meta_type diff --git a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_deleteAction.py b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_deleteAction.py index eb824369e46a010a3a53f41ab3b45e97049a7675..46b867454fdae60e0c4c64c33ad65ccd0473a6bd 100644 --- a/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_deleteAction.py +++ b/bt5/erp5_ui_test/SkinTemplateItem/portal_skins/erp5_ui_test/PortalType_deleteAction.py @@ -1,3 +1,5 @@ +# this script has a parameter named `id` +# pylint: disable=redefined-builtin """Delete an action on a type informations from types tool. """ assert context.meta_type in ('ERP5 Type Information', 'ERP5 Base Type'), context.meta_type diff --git a/bt5/erp5_ui_test/bt/skip_coding_style_test b/bt5/erp5_ui_test/bt/skip_coding_style_test deleted file mode 100644 index 56a6051ca2b02b04ef92d5150c9ef600403cb1de..0000000000000000000000000000000000000000 --- a/bt5/erp5_ui_test/bt/skip_coding_style_test +++ /dev/null @@ -1 +0,0 @@ -1 \ No newline at end of file diff --git a/bt5/erp5_web_renderjs_ui_test/bt/skip_coding_style_test b/bt5/erp5_web_renderjs_ui_test/bt/skip_coding_style_test deleted file mode 100644 index 56a6051ca2b02b04ef92d5150c9ef600403cb1de..0000000000000000000000000000000000000000 --- a/bt5/erp5_web_renderjs_ui_test/bt/skip_coding_style_test +++ /dev/null @@ -1 +0,0 @@ -1 \ No newline at end of file diff --git a/product/ERP5Type/CodingStyle.py b/product/ERP5Type/CodingStyle.py index a707f80c357eb4f766ace0559e54b1fddd619c64..13cec82d9ef8c1af40cea6f9cd56f967e7b1e2dc 100644 --- a/product/ERP5Type/CodingStyle.py +++ b/product/ERP5Type/CodingStyle.py @@ -82,6 +82,7 @@ def getSkinPrefixList(self): 'DCWorkflow', # some workflow script use this, not sure it's correct. 'SkinsTool', + 'MailHost', 'Entity', # A base class for Person / Organisation 'Zuite', # Products.Zelenium test suites @@ -97,10 +98,32 @@ def getSkinPrefixList(self): # Some skin names that does not respect our conventions but are ignored, for example -# when this naming is used by zope. +# when this naming is used by zope or scripts that changing would be too hard. ignored_skin_id_set = { 'twiddleAuthCookie', 'setAuthCookie', + 'ERP5Document_getHateoas', + 'Script_getParams', + 'AccessTabZuite_disablePreference', + 'AccessTabZuite_setPreference', + 'BTZuite_CommonTemplate', + 'BTZuite_reset', + 'FooViewDummyMultiListFieldDialog_setFieldPropertyList', + 'FooView_setFieldsProperties', + 'ListBoxDialogModeZuite_CommonTemplate', + 'ListBoxDialogModeZuite_reset', + 'ListBoxZuite_CommonTemplate', + 'ListBoxZuite_getSelectionCheckedUidsAsHtml', + 'ListBoxZuite_reset', + 'ListBoxZuite_resetReportSelections', + 'ListBoxZuite_setPreferredListboxViewModeLineCount', + 'MatrixBoxZuite_CommonTemplate', + 'OOoImportZuite_importFile', + 'OOoImportZuite_reset', + 'PTZuite_CommonTemplate', + 'PortalType_addAction', + 'PortalType_deleteAction', + 'RelationFieldZuite_CommonTemplate', } # Generic method to check consistency of a skin item