erp5_core: define what activity_watcher gadget should do when things are not working (part 2)

simplify error handling and avoid code duplication (thanks Romain for advices)

product/ERP5/bootstrap/erp5_core/SkinTemplateItem/portal_skins/erp5_core/gadget_activity_watcher.js.js

@@ -57,22 +57,17 @@
 
             form_gadget.props.element.querySelector(".activity_watcher_gadget")
                             .innerHTML = html_content;
-            return RSVP.delay(1000);
-          })
-          .push(function () {
-            return getDataExamine();
-          })
-          .push(undefined, function (error) {
+          }, function (error) {
             //Exception is raised if network is lost for some reasons,
             //in this case, try patiently until network is back.
-            //There is probably more clean ways
-            console.log("error", error);
-            return new RSVP.Queue().push(function () {
+            console.log("Unable to fetch activities from ERP5", error);
+          })
+          .push(function () {
             return RSVP.delay(1000);
-            }).push(function () {
+          })
+          .push(function () {
             return getDataExamine();
           });
-          });
       }
       return queue.push(function () {
         return getDataExamine();