Extract JS even if type='text/javascript' not set

18d4f072 · Thibaut Frain · 4965eab4 · 18d4f072 · 18d4f072
Commit 18d4f072 authored Apr 07, 2014 by Thibaut Frain
Show whitespace changes
Inline Side-by-side

Showing with 13 additions and 1 deletion

renderjs.js renderjs.js +3 -1

test/renderjs_test.js test/renderjs_test.js +10 -0

No files found.
--- a/renderjs.js
+++ b/renderjs.js
@@ -605,7 +605,9 @@
          // element.href returns absolute URL in firefox but "" in chrome;
          if (element.rel === "stylesheet") {
            settings.required_css_list.push(element.getAttribute("href"));
-          } else if (element.type === "text/javascript") {
+          } else if (element.nodeName === "SCRIPT" &&
+                     (element.type === "text/javascript" ||
+                      !element.type)) {
            settings.required_js_list.push(element.getAttribute("src"));
          } else if (element.rel === "http://www.renderjs.org/rel/interface") {
            settings.interface_list.push(element.getAttribute("href"));

--- a/test/renderjs_test.js
+++ b/test/renderjs_test.js
@@ -298,6 +298,16 @@
    });
  });
+  test('Extract JS even if type="text/javascript" not set', function () {
+    var settings,
+      html = "<html><head>" +
+        "<script src='../lib/qunit/qunit.js'></script" +
+        "</head></html>";
+    settings = parseGadgetHTML(html, "http://test.org/foo");
+    deepEqual(settings.required_js_list,
+              ["../lib/qunit/qunit.js"]);
+  });
  /////////////////////////////////////////////////////////////////
  // declareGadgetKlass
  /////////////////////////////////////////////////////////////////