Merge branch 'fix-username-period-migration' into 'master'

Fix username period migration to preserve uniqueness of names and paths.

See merge request !534

app/models/namespace.rb

@@ -59,6 +59,7 @@ class Namespace < ActiveRecord::Base
     end
 
     def clean_path(path)
+      path = path.dup
       path.gsub!(/@.*\z/,             "")
       path.gsub!(/\.git\z/,           "")
       path.gsub!(/\A-+/,              "")

db/migrate/20150324133047_remove_periods_at_ends_of_usernames.rb

@@ -3,21 +3,21 @@ class RemovePeriodsAtEndsOfUsernames < ActiveRecord::Migration
 
   class Namespace < ActiveRecord::Base
     class << self
-      def by_path(path)
-        where('lower(path) = :value', value: path.downcase).first
+      def find_by_path_or_name(path)
+        find_by("lower(path) = :path OR lower(name) = :path", path: path.downcase)
       end
 
       def clean_path(path)
         path = path.dup
         path.gsub!(/@.*\z/,             "")
         path.gsub!(/\.git\z/,           "")
-        path.gsub!(/\A-/,               "")
-        path.gsub!(/.\z/,               "")
+        path.gsub!(/\A-+/,              "")
+        path.gsub!(/\.+\z/,             "")
         path.gsub!(/[^a-zA-Z0-9_\-\.]/, "")
 
         counter = 0
         base = path
-        while Namespace.by_path(path).present?
+        while Namespace.find_by_path_or_name(path)
           counter += 1
           path = "#{base}#{counter}"
         end