Commit 1d945945 authored by Dmitriy Zaporozhets's avatar Dmitriy Zaporozhets

Merge branch 'sn-push-email-plussign' into 'master'

Use entity number for plus sign in push emails

Was doing some testing today and found that both outlook and gmail had issues displaying the html content produced for push emails when a file was added.

This is how gmail shows it:
![Gmail_name](https://gitlab.com/stevenorman/gitlab-ce/uploads/24be115dbae97997bc02e2ec70d9870c/Gmail_name.png)

And this is for Outlook:
![Outlook_name](https://gitlab.com/stevenorman/gitlab-ce/uploads/4b5a54956139d36d78f9c61c83e99928/Outlook_name.png)

iOS devices work with the + entity, as does Mail on OS X, but I'm wondering if it is only available for newer html parsers (a quick browse on the w3c site seems to show that it was added in html 5).

Changing the entity to `+` and both gmail and outlook and iOS and Mail.

See merge request !721
parents ef3e0931 10871732
...@@ -35,7 +35,7 @@ ...@@ -35,7 +35,7 @@
= diff.new_path = diff.new_path
- elsif diff.new_file - elsif diff.new_file
%span.new-file %span.new-file
+ +
= diff.new_path = diff.new_path
- else - else
= diff.new_path = diff.new_path
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment