Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
2c4daf1a
Commit
2c4daf1a
authored
Sep 14, 2015
by
Valery Sizov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix part of specs
parent
4c53cc0e
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
100 additions
and
98 deletions
+100
-98
spec/requests/ci/builds_spec.rb
spec/requests/ci/builds_spec.rb
+1
-1
spec/requests/ci/commits_spec.rb
spec/requests/ci/commits_spec.rb
+1
-1
spec/services/ci/create_commit_service_spec.rb
spec/services/ci/create_commit_service_spec.rb
+98
-96
No files found.
spec/requests/ci/builds_spec.rb
View file @
2c4daf1a
...
...
@@ -9,7 +9,7 @@ describe "Builds" do
describe
"GET /:project/builds/:id/status.json"
do
before
do
get
status_project_build_path
(
@project
,
@build
),
format: :json
get
status_
ci_
project_build_path
(
@project
,
@build
),
format: :json
end
it
{
expect
(
response
.
status
).
to
eq
(
200
)
}
...
...
spec/requests/ci/commits_spec.rb
View file @
2c4daf1a
...
...
@@ -8,7 +8,7 @@ describe "Commits" do
describe
"GET /:project/refs/:ref_name/commits/:id/status.json"
do
before
do
get
status_
project_ref_commit
_path
(
@project
,
@commit
.
ref
,
@commit
.
sha
),
format: :json
get
status_
ci_project_ref_commits
_path
(
@project
,
@commit
.
ref
,
@commit
.
sha
),
format: :json
end
it
{
expect
(
response
.
status
).
to
eq
(
200
)
}
...
...
spec/services/ci/create_commit_service_spec.rb
View file @
2c4daf1a
require
'spec_helper'
describe
Ci
::
CreateCommitService
do
module
Ci
describe
CreateCommitService
do
let
(
:service
)
{
CreateCommitService
.
new
}
let
(
:project
)
{
FactoryGirl
.
create
(
:
project
)
}
let
(
:project
)
{
FactoryGirl
.
create
(
:ci_
project
)
}
describe
:execute
do
context
'valid params'
do
...
...
@@ -16,11 +17,11 @@ describe Ci::CreateCommitService do
)
end
it
{
commit
.
should
be_kind_of
(
Commit
)
}
it
{
commit
.
should
be_valid
}
it
{
commit
.
should
be_persisted
}
it
{
commit
.
should
==
project
.
commits
.
last
}
it
{
commit
.
builds
.
first
.
should
be_kind_of
(
Build
)
}
it
{
expect
(
commit
).
to
be_kind_of
(
Commit
)
}
it
{
expect
(
commit
).
to
be_valid
}
it
{
expect
(
commit
).
to
be_persisted
}
it
{
expect
(
commit
).
to
eq
(
project
.
commits
.
last
)
}
it
{
expect
(
commit
.
builds
.
first
).
to
be_kind_of
(
Build
)
}
end
context
"skip tag if there is no build for it"
do
...
...
@@ -32,7 +33,7 @@ describe Ci::CreateCommitService do
ci_yaml_file:
gitlab_ci_yaml
,
commits:
[
{
message:
"Message"
}
]
)
result
.
should
be_persisted
expect
(
result
).
to
be_persisted
end
it
"creates commit if there is no appropriate job but deploy job has right ref setting"
do
...
...
@@ -45,7 +46,7 @@ describe Ci::CreateCommitService do
ci_yaml_file:
config
,
commits:
[
{
message:
"Message"
}
]
)
result
.
should
be_persisted
expect
(
result
).
to
be_persisted
end
end
...
...
@@ -59,8 +60,8 @@ describe Ci::CreateCommitService do
commits:
commits
,
ci_yaml_file:
gitlab_ci_yaml
)
commit
.
builds
.
any?
.
should
be_
false
commit
.
status
.
should
==
"skipped"
expect
(
commit
.
builds
.
any?
).
to
be
false
expect
(
commit
.
status
).
to
eq
(
"skipped"
)
end
it
"does not skips builds creation if there is no [ci skip] tag in commit message"
do
...
...
@@ -74,7 +75,7 @@ describe Ci::CreateCommitService do
ci_yaml_file:
gitlab_ci_yaml
)
commit
.
builds
.
first
.
name
.
should
==
"staging"
expect
(
commit
.
builds
.
first
.
name
).
to
eq
(
"staging"
)
end
it
"skips builds creation if there is [ci skip] tag in commit message and yaml is invalid"
do
...
...
@@ -86,8 +87,8 @@ describe Ci::CreateCommitService do
commits:
commits
,
ci_yaml_file:
"invalid: file"
)
commit
.
builds
.
any?
.
should
be_
false
commit
.
status
.
should
==
"skipped"
expect
(
commit
.
builds
.
any?
).
to
be
false
expect
(
commit
.
status
).
to
eq
(
"skipped"
)
end
end
...
...
@@ -100,7 +101,7 @@ describe Ci::CreateCommitService do
commits:
commits
,
ci_yaml_file:
gitlab_ci_yaml
)
commit
.
builds
.
count
(
:all
).
should
==
2
expect
(
commit
.
builds
.
count
(
:all
)).
to
eq
(
2
)
commit
=
service
.
execute
(
project
,
ref:
'refs/heads/master'
,
...
...
@@ -109,7 +110,7 @@ describe Ci::CreateCommitService do
commits:
commits
,
ci_yaml_file:
gitlab_ci_yaml
)
commit
.
builds
.
count
(
:all
).
should
==
2
expect
(
commit
.
builds
.
count
(
:all
)).
to
eq
(
2
)
end
it
"creates commit with failed status if yaml is invalid"
do
...
...
@@ -123,8 +124,9 @@ describe Ci::CreateCommitService do
ci_yaml_file:
"invalid: file"
)
commit
.
status
.
should
==
"failed"
commit
.
builds
.
any?
.
should
be_false
expect
(
commit
.
status
).
to
eq
(
"failed"
)
expect
(
commit
.
builds
.
any?
).
to
be
false
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment