use jquery object in togglePopover

3283386a · Luke Bennett · 8d43fe4e · 3283386a
Commit 3283386a authored Apr 13, 2018 by Luke Bennett
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

app/assets/javascripts/shared/popover.js app/assets/javascripts/shared/popover.js +4 -3

No files found.
--- a/app/assets/javascripts/shared/popover.js
+++ b/app/assets/javascripts/shared/popover.js
@@ -2,12 +2,13 @@ import $ from 'jquery';
 import _ from 'underscore';
 export function togglePopover(show) {
-  const isAlreadyShown = this.hasClass('js-popover-show');
+  const $popover = $(this);
+  const isAlreadyShown = $popover.hasClass('js-popover-show');
  if ((show && isAlreadyShown) || (!show && !isAlreadyShown)) {
    return false;
  }
-  this.popover(show ? 'show' : 'hide');
+  $popover.popover(show ? 'show' : 'hide');
-  this.toggleClass('disable-animation js-popover-show', show);
+  $popover.toggleClass('disable-animation js-popover-show', show);
  return true;
 }