Uses update URL to update the status of a todo

app/assets/javascripts/right_sidebar.js.coffee

@@ -47,27 +47,34 @@ class @Sidebar
       .off 'click', '.js-issuable-todo'
       .on 'click', '.js-issuable-todo', @toggleTodo
 
-  toggleTodo: ->
-    $this = $(@)
+  toggleTodo: (e) =>
+    $this = $(e.currentTarget)
     $todoLoading = $('.js-issuable-todo-loading')
     $btnText = $('.js-issuable-todo-text', $this)
+    ajaxType = if $this.attr('data-id') then 'PATCH' else 'POST'
+    ajaxUrlExtra = if $this.attr('data-id') then "/#{$this.attr('data-id')}" else ''
 
     $.ajax(
-      url: $this.data('url')
-      type: 'POST'
+      url: "#{$this.data('url')}#{ajaxUrlExtra}"
+      type: ajaxType
       dataType: 'json'
       data:
-        todo_id: $this.attr('data-id')
         issuable_id: $this.data('issuable')
         issuable_type: $this.data('issuable-type')
-      beforeSend: ->
-        $this.disable()
+      beforeSend: =>
+        @beforeTodoSend($this, $todoLoading)
+    ).done (data) =>
+      @todoUpdateDone(data, $this, $btnText, $todoLoading)
+
+  beforeTodoSend: ($btn, $todoLoading) ->
+    $btn.disable()
     $todoLoading.removeClass 'hidden'
-    ).done (data) ->
+
+  todoUpdateDone: (data, $btn, $btnText, $todoLoading) ->
     $todoPendingCount = $('.todos-pending-count')
     $todoPendingCount.text data.count
 
-      $this.enable()
+    $btn.enable()
     $todoLoading.addClass 'hidden'
 
     if data.count is 0
@@ -76,15 +83,15 @@ class @Sidebar
       $todoPendingCount.removeClass 'hidden'
 
     if data.todo?
-        $this
-          .attr 'aria-label', $this.data('mark-text')
+      $btn
+        .attr 'aria-label', $btn.data('mark-text')
         .attr 'data-id', data.todo.id
-        $btnText.text $this.data('mark-text')
+      $btnText.text $btn.data('mark-text')
     else
-        $this
-          .attr 'aria-label', $this.data('todo-text')
+      $btn
+        .attr 'aria-label', $btn.data('todo-text')
         .removeAttr 'data-id'
-        $btnText.text $this.data('todo-text')
+      $btnText.text $btn.data('todo-text')
 
   sidebarDropdownLoading: (e) ->
     $sidebarCollapsedIcon = $(@).closest('.block').find('.sidebar-collapsed-icon')

app/controllers/projects/todos_controller.rb

 class Projects::TodosController < Projects::ApplicationController
   def create
-    json_data = Hash.new
-
-    if params[:todo_id].nil?
     TodoService.new.mark_todo(issuable, current_user)
 
-      json_data[:todo] = current_user.todos.find_by(state: :pending, action: Todo::MARKED, target_id: issuable.id)
-    else
-      current_user.todos.find_by_id(params[:todo_id]).update(state: :done)
+    render json: {
+      todo: current_user.todos.find_by(state: :pending, action: Todo::MARKED, target_id: issuable.id),
+      count: current_user.todos.pending.count,
+    }
   end
 
-    render json: json_data.merge({ count: current_user.todos.pending.count })
+  def update
+    current_user.todos.find_by_id(params[:id]).update(state: :done)
+
+    render json: {
+      count: current_user.todos.pending.count,
+    }
   end
 
   private

app/views/shared/issuable/_sidebar.html.haml

@@ -9,7 +9,7 @@
       %a.gutter-toggle.pull-right.js-sidebar-toggle{ role: "button", href: "#", aria: { label: "Toggle sidebar" } }
         = sidebar_gutter_toggle_icon
       - if current_user
-        %button.btn.btn-default.issuable-header-btn.pull-right.js-issuable-todo{ type: "button", aria: { label: (todo.nil? ? "Add Todo" : "Mark Done") }, data: { todo_text: "Add Todo", mark_text: "Mark Done", id: (todo.id unless todo.nil?), issuable: issuable.id, issuable_type: issuable.class.name.underscore, url: namespace_project_todos_path(@project.namespace, @project, :json) } }
+        %button.btn.btn-default.issuable-header-btn.pull-right.js-issuable-todo{ type: "button", aria: { label: (todo.nil? ? "Add Todo" : "Mark Done") }, data: { todo_text: "Add Todo", mark_text: "Mark Done", id: (todo.id unless todo.nil?), issuable: issuable.id, issuable_type: issuable.class.name.underscore, url: namespace_project_todos_path(@project.namespace, @project) } }
           %span.js-issuable-todo-text
             - if todo.nil?
               Add Todo

config/routes.rb

@@ -789,7 +789,7 @@ Rails.application.routes.draw do
           end
         end
 
-        resources :todos, only: [:create], constraints: { id: /\d+/ }
+        resources :todos, only: [:create, :update], constraints: { id: /\d+/ }
 
         resources :uploads, only: [:create] do
           collection do