Commit 3918fce5 authored by Baldinof's avatar Baldinof

Hide number sign for string prefixed external issues

parent b372968e
...@@ -34,15 +34,13 @@ class ExternalIssue ...@@ -34,15 +34,13 @@ class ExternalIssue
%r{(?<issue>\b([A-Z][A-Z0-9_]+-)\d+)} %r{(?<issue>\b([A-Z][A-Z0-9_]+-)\d+)}
end end
def self.reference_prefix
'#'
end
def to_reference(_from_project = nil) def to_reference(_from_project = nil)
id id
end end
def reference_link_text(from_project = nil) def reference_link_text(from_project = nil)
"#{self.class.reference_prefix}#{id}" return "##{id}" if /^\d+$/.match(id)
id
end end
end end
...@@ -38,8 +38,17 @@ describe ExternalIssue, models: true do ...@@ -38,8 +38,17 @@ describe ExternalIssue, models: true do
end end
describe '#reference_link_text' do describe '#reference_link_text' do
it 'returns a String reference to the object' do context 'if issue id has a prefix' do
expect(issue.reference_link_text).to eq '#EXT-1234' it 'returns the issue ID' do
expect(issue.reference_link_text).to eq 'EXT-1234'
end
end
context 'if issue id is a number' do
let(:issue) { described_class.new('1234', project) }
it 'returns the issue ID prefixed by #' do
expect(issue.reference_link_text).to eq '#1234'
end
end end
end end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment