Commit 8e7929b8 authored by Phil Hughes's avatar Phil Hughes

Checks if rendered count has changed rather than relying on key char

parent ecf08ae1
...@@ -615,7 +615,6 @@ require('./window')(function(w){ ...@@ -615,7 +615,6 @@ require('./window')(function(w){
if (elOffsetTop > filterDropdownBottom) { if (elOffsetTop > filterDropdownBottom) {
filterDropdownEl.scrollTop = elOffsetTop - filterDropdownBottom; filterDropdownEl.scrollTop = elOffsetTop - filterDropdownBottom;
console.log(filterDropdownEl.scrollTop);
} }
} }
} }
......
...@@ -3,10 +3,11 @@ ...@@ -3,10 +3,11 @@
/* global droplab */ /* global droplab */
require('../window')(function(w){ require('../window')(function(w){
var charRegex = new RegExp('^.$', 'g');
w.droplabFilter = { w.droplabFilter = {
keydownWrapper: function(e){ keydownWrapper: function(e){
var hiddenCount = 0;
var dataHiddenCount = 0;
var list = e.detail.hook.list; var list = e.detail.hook.list;
var data = list.data; var data = list.data;
var value = e.detail.hook.trigger.value.toLowerCase(); var value = e.detail.hook.trigger.value.toLowerCase();
...@@ -18,10 +19,6 @@ require('../window')(function(w){ ...@@ -18,10 +19,6 @@ require('../window')(function(w){
return; return;
} }
if (!charRegex.test(e.detail.key)) {
return;
}
if (config && config.filterFunction && typeof config.filterFunction === 'function') { if (config && config.filterFunction && typeof config.filterFunction === 'function') {
filterFunction = config.filterFunction; filterFunction = config.filterFunction;
} else { } else {
...@@ -32,11 +29,22 @@ require('../window')(function(w){ ...@@ -32,11 +29,22 @@ require('../window')(function(w){
}; };
} }
dataHiddenCount = data.filter(function(o) {
return !o.droplab_hidden;
}).length;
matches = data.map(function(o) { matches = data.map(function(o) {
return filterFunction(o, value); return filterFunction(o, value);
}); });
hiddenCount = matches.filter(function(o) {
return !o.droplab_hidden;
}).length;
if (dataHiddenCount !== hiddenCount) {
list.render(matches); list.render(matches);
list.currentIndex = 0; list.currentIndex = 0;
}
}, },
init: function init(hookInput) { init: function init(hookInput) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment