Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
94e9d571
Commit
94e9d571
authored
Jul 11, 2016
by
James Lopez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
remove fix validatable import url migration
parent
01d1be7b
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
106 deletions
+0
-106
db/migrate/20160620110927_fix_no_validatable_import_url.rb
db/migrate/20160620110927_fix_no_validatable_import_url.rb
+0
-106
No files found.
db/migrate/20160620110927_fix_no_validatable_import_url.rb
deleted
100644 → 0
View file @
01d1be7b
# Updates project records containing invalid URLs using the AddressableUrlValidator.
# This is optimized assuming the number of invalid records is low, but
# we still need to loop through all the projects with an +import_url+
# so we use batching for the latter.
#
# This migration is non-reversible as we would have to keep the old data.
class
FixNoValidatableImportUrl
<
ActiveRecord
::
Migration
include
Gitlab
::
Database
::
MigrationHelpers
class
SqlBatches
attr_reader
:results
,
:query
def
initialize
(
batch_size:
1000
,
query
:)
@offset
=
0
@batch_size
=
batch_size
@query
=
query
@results
=
[]
end
def
next?
@results
=
ActiveRecord
::
Base
.
connection
.
exec_query
(
batched_sql
)
@offset
+=
@batch_size
@results
.
any?
end
private
def
batched_sql
"
#{
@query
}
LIMIT
#{
@batch_size
}
OFFSET
#{
@offset
}
"
end
end
# AddressableValidator - Snapshot of AddressableUrlValidator
module
AddressableUrlValidatorSnap
extend
self
def
valid_url?
(
value
)
return
false
unless
value
valid_uri?
(
value
)
&&
valid_protocol?
(
value
)
rescue
Addressable
::
URI
::
InvalidURIError
false
end
def
valid_uri?
(
value
)
Addressable
::
URI
.
parse
(
value
).
is_a?
(
Addressable
::
URI
)
end
def
valid_protocol?
(
value
)
value
=~
/\A
#{
URI
.
regexp
(
%w(http https ssh git)
)
}
\z/
end
end
def
up
unless
defined?
(
Addressable
::
URI
::
InvalidURIError
)
say
(
'Skipping cleaning up invalid import URLs as class from Addressable is missing'
)
return
end
say
(
'Nullifying empty import URLs'
)
nullify_empty_urls
say
(
'Cleaning up invalid import URLs... This may take a few minutes if we have a large number of imported projects.'
)
process_invalid_import_urls
end
def
process_invalid_import_urls
batches
=
SqlBatches
.
new
(
query:
"SELECT id, import_url FROM projects WHERE import_url IS NOT NULL"
)
while
batches
.
next?
project_ids
=
[]
batches
.
results
.
each
do
|
result
|
project_ids
<<
result
[
'id'
]
unless
valid_url?
(
result
[
'import_url'
])
end
process_batch
(
project_ids
)
end
end
def
process_batch
(
project_ids
)
Thread
.
new
do
begin
project_ids
.
each
{
|
project_id
|
cleanup_import_url
(
project_id
)
}
ensure
ActiveRecord
::
Base
.
connection
.
close
end
end
.
join
end
def
valid_url?
(
url
)
AddressableUrlValidatorSnap
.
valid_url?
(
url
)
end
def
cleanup_import_url
(
project_id
)
execute
(
"UPDATE projects SET import_url = NULL WHERE id =
#{
project_id
}
"
)
end
def
nullify_empty_urls
execute
(
"UPDATE projects SET import_url = NULL WHERE import_url = ''"
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment