satisfy rubocop

features/crowd_login_form.feature → features/login_form.feature

-Feature: Crowd login form
+Feature: Login form
   Scenario: I see crowd form
     Given Crowd integration enabled
     When I visit sign in page

features/steps/crowd_login_form.rb → features/steps/login_form.rb

-class Spinach::Features::CrowdLoginForm < Spinach::FeatureSteps
+class Spinach::Features::LoginForm < Spinach::FeatureSteps
   include SharedAuthentication
   include SharedPaths
   include SharedSnippet
@@ -6,13 +6,17 @@ class Spinach::Features::CrowdLoginForm < Spinach::FeatureSteps
   include SharedSearch
 
   step 'Crowd integration enabled' do
-    Gitlab::OAuth::Provider.should_receive(:providers).and_return([:crowd])
+    @providers_orig = Gitlab::OAuth::Provider.providers
+    @omniauth_conf_orig = Gitlab.config.omniauth.enabled
+    expect(Gitlab::OAuth::Provider).to receive(:providers).and_return([:crowd])
     allow_any_instance_of(ApplicationHelper).to receive(:user_omniauth_authorize_path).and_return(root_path)
-    Gitlab.config.omniauth.should_receive(:enabled).and_return(true)
+    expect(Gitlab.config.omniauth).to receive(:enabled).and_return(true)
   end
 
   step 'I should see Crowd login form' do
     expect(page).to have_selector '#tab-crowd form'
+    Gitlab::OAuth::Provider.stub(:providers).and_return(@providers_orig)
+    Gitlab.config.omniauth.stub(:enabled).and_return(@omniauth_conf_orig)
   end
 
   step 'I visit sign in page' do