Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
9d7971c1
Commit
9d7971c1
authored
Aug 20, 2017
by
Mehdi Lahmam
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused `IssuesHelper#merge_requests_sentence`
Its last usage has been removed at
eb3e7bdf
.
parent
39b313ba
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
18 deletions
+0
-18
app/helpers/issues_helper.rb
app/helpers/issues_helper.rb
+0
-8
spec/helpers/issues_helper_spec.rb
spec/helpers/issues_helper_spec.rb
+0
-10
No files found.
app/helpers/issues_helper.rb
View file @
9d7971c1
...
@@ -86,14 +86,6 @@ module IssuesHelper
...
@@ -86,14 +86,6 @@ module IssuesHelper
return
'hidden'
if
issue
.
closed?
==
closed
return
'hidden'
if
issue
.
closed?
==
closed
end
end
def
merge_requests_sentence
(
merge_requests
)
# Sorting based on the `!123` or `group/project!123` reference will sort
# local merge requests first.
merge_requests
.
map
do
|
merge_request
|
merge_request
.
to_reference
(
@project
)
end
.
sort
.
to_sentence
(
last_word_connector:
', or '
)
end
def
confidential_icon
(
issue
)
def
confidential_icon
(
issue
)
icon
(
'eye-slash'
)
if
issue
.
confidential?
icon
(
'eye-slash'
)
if
issue
.
confidential?
end
end
...
...
spec/helpers/issues_helper_spec.rb
View file @
9d7971c1
...
@@ -58,16 +58,6 @@ describe IssuesHelper do
...
@@ -58,16 +58,6 @@ describe IssuesHelper do
end
end
end
end
describe
"merge_requests_sentence"
do
subject
{
merge_requests_sentence
(
merge_requests
)}
let
(
:merge_requests
)
do
[
build
(
:merge_request
,
iid:
1
),
build
(
:merge_request
,
iid:
2
),
build
(
:merge_request
,
iid:
3
)]
end
it
{
is_expected
.
to
eq
(
"!1, !2, or !3"
)
}
end
describe
'#award_user_list'
do
describe
'#award_user_list'
do
it
"returns a comma-separated list of the first X users"
do
it
"returns a comma-separated list of the first X users"
do
user
=
build_stubbed
(
:user
,
name:
'Joe'
)
user
=
build_stubbed
(
:user
,
name:
'Joe'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment