Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
a3c38789
Commit
a3c38789
authored
7 years ago
by
Takuya Noguchi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Stop loading spinner on error of issuable templates
parent
ba02e3a5
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
1 deletion
+6
-1
app/assets/javascripts/templates/issuable_template_selector.js
...ssets/javascripts/templates/issuable_template_selector.js
+1
-1
changelogs/unreleased/40029-better-error-handling-on-issuable-templates.yml
...sed/40029-better-error-handling-on-issuable-templates.yml
+5
-0
No files found.
app/assets/javascripts/templates/issuable_template_selector.js
View file @
a3c38789
...
...
@@ -32,8 +32,8 @@ export default class IssuableTemplateSelector extends TemplateSelector {
this
.
startLoadingSpinner
();
Api
.
issueTemplate
(
this
.
namespacePath
,
this
.
projectPath
,
query
.
name
,
this
.
issuableType
,
(
err
,
currentTemplate
)
=>
{
this
.
currentTemplate
=
currentTemplate
;
if
(
err
)
return
;
// Error handled by global AJAX error handler
this
.
stopLoadingSpinner
();
if
(
err
)
return
;
// Error handled by global AJAX error handler
this
.
setInputValueToTemplateContent
();
});
return
;
...
...
This diff is collapsed.
Click to expand it.
changelogs/unreleased/40029-better-error-handling-on-issuable-templates.yml
0 → 100644
View file @
a3c38789
---
title
:
Stop loading spinner on error of issuable templates
merge_request
:
16600
author
:
Takuya Noguchi
type
:
fixed
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment