Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
a8339fe1
Commit
a8339fe1
authored
Apr 06, 2017
by
Douwe Maan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix views after rebase
parent
f112f81d
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
5 additions
and
3 deletions
+5
-3
app/helpers/notes_helper.rb
app/helpers/notes_helper.rb
+4
-2
app/views/discussions/_discussion.html.haml
app/views/discussions/_discussion.html.haml
+1
-1
No files found.
app/helpers/notes_helper.rb
View file @
a8339fe1
...
@@ -61,7 +61,7 @@ module NotesHelper
...
@@ -61,7 +61,7 @@ module NotesHelper
end
end
def
discussion_diff_path
(
discussion
)
def
discussion_diff_path
(
discussion
)
if
discussion
.
for_merge_request?
if
discussion
.
for_merge_request?
&&
discussion
.
diff_discussion?
if
discussion
.
active?
if
discussion
.
active?
# Without a diff ID, the link always points to the latest diff version
# Without a diff ID, the link always points to the latest diff version
diff_id
=
nil
diff_id
=
nil
...
@@ -75,7 +75,9 @@ module NotesHelper
...
@@ -75,7 +75,9 @@ module NotesHelper
diffs_namespace_project_merge_request_path
(
discussion
.
project
.
namespace
,
discussion
.
project
,
discussion
.
noteable
,
diff_id:
diff_id
,
anchor:
discussion
.
line_code
)
diffs_namespace_project_merge_request_path
(
discussion
.
project
.
namespace
,
discussion
.
project
,
discussion
.
noteable
,
diff_id:
diff_id
,
anchor:
discussion
.
line_code
)
elsif
discussion
.
for_commit?
elsif
discussion
.
for_commit?
namespace_project_commit_path
(
discussion
.
project
.
namespace
,
discussion
.
project
,
discussion
.
noteable
,
anchor:
discussion
.
line_code
)
anchor
=
discussion
.
line_code
if
discussion
.
diff_discussion?
namespace_project_commit_path
(
discussion
.
project
.
namespace
,
discussion
.
project
,
discussion
.
noteable
,
anchor:
anchor
)
end
end
end
end
end
end
app/views/discussions/_discussion.html.haml
View file @
a8339fe1
...
@@ -29,7 +29,7 @@
...
@@ -29,7 +29,7 @@
=
link_to
commit
.
short_id
,
url
,
class:
'monospace'
=
link_to
commit
.
short_id
,
url
,
class:
'monospace'
-
else
-
else
a deleted commit
a deleted commit
-
els
e
-
els
if
discussion
.
diff_discussion?
=
conditional_link_to
url
.
present?
,
url
do
=
conditional_link_to
url
.
present?
,
url
do
-
if
discussion
.
active?
-
if
discussion
.
active?
the diff
the diff
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment