Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
a8f22ddf
Commit
a8f22ddf
authored
Jul 17, 2017
by
Simon Knox
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
move click handler to button. when on the icon it wasn't triggered in firefox
parent
00861676
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
2 deletions
+6
-2
app/views/projects/cycle_analytics/show.html.haml
app/views/projects/cycle_analytics/show.html.haml
+2
-2
changelogs/unreleased/35164-cycle-analytics-firefox.yml
changelogs/unreleased/35164-cycle-analytics-firefox.yml
+4
-0
No files found.
app/views/projects/cycle_analytics/show.html.haml
View file @
a8f22ddf
...
...
@@ -9,8 +9,8 @@
#cycle-analytics
{
class:
container_class
,
"v-cloak"
=>
"true"
,
data:
{
request_path:
project_cycle_analytics_path
(
@project
)
}
}
-
if
@cycle_analytics_no_data
.landing.content-block
{
"v-if"
=>
"!isOverviewDialogDismissed"
}
%button
.dismiss-button
{
type:
'button'
,
'aria-label'
:
'Dismiss Cycle Analytics introduction box'
}
=
icon
(
"times"
,
"@click"
=>
"dismissOverviewDialog()"
)
%button
.dismiss-button
{
type:
'button'
,
'aria-label'
:
'Dismiss Cycle Analytics introduction box'
,
"@click"
=>
"dismissOverviewDialog()"
}
=
icon
(
"times"
)
.svg-container
=
custom_icon
(
'icon_cycle_analytics_splash'
)
.inner-content
...
...
changelogs/unreleased/35164-cycle-analytics-firefox.yml
0 → 100644
View file @
a8f22ddf
---
title
:
allow closing Cycle Analytics intro box in firefox
merge_request
:
author
:
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment