Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Jérome Perrin
gitlab-ce
Commits
afba21f6
Commit
afba21f6
authored
Jul 19, 2017
by
Ben Kochie
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update piplines created metric name
* Use `_total` naming convention. * Add to metrics documentation.
parent
3453bc32
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
2 deletions
+3
-2
app/services/ci/create_pipeline_service.rb
app/services/ci/create_pipeline_service.rb
+1
-1
doc/administration/monitoring/prometheus/gitlab_metrics.md
doc/administration/monitoring/prometheus/gitlab_metrics.md
+1
-0
spec/services/ci/create_pipeline_service_spec.rb
spec/services/ci/create_pipeline_service_spec.rb
+1
-1
No files found.
app/services/ci/create_pipeline_service.rb
View file @
afba21f6
...
...
@@ -135,7 +135,7 @@ module Ci
end
def
pipeline_created_counter
@pipeline_created_counter
||=
Gitlab
::
Metrics
.
counter
(
:pipelines_created_
count
,
"Pipelines created count
"
)
@pipeline_created_counter
||=
Gitlab
::
Metrics
.
counter
(
:pipelines_created_
total
,
"Counter of pipelines created
"
)
end
end
end
doc/administration/monitoring/prometheus/gitlab_metrics.md
View file @
afba21f6
...
...
@@ -39,6 +39,7 @@ In this experimental phase, only a few metrics are available:
| filesystem_readable | Gauge | Whether or not the filesystem is readable |
| http_requests_total | Counter | Rack request count |
| http_request_duration_seconds | Histogram | HTTP response time from rack middleware |
| pipelines_created_total | Counter | Counter of pipelines created |
| rack_uncaught_errors_total | Counter | Rack connections handling uncaught errors count |
| redis_ping_timeout | Gauge | Whether or not the last redis ping timed out |
| redis_ping_success | Gauge | Whether or not the last redis ping succeeded |
...
...
spec/services/ci/create_pipeline_service_spec.rb
View file @
afba21f6
...
...
@@ -40,7 +40,7 @@ describe Ci::CreatePipelineService, :services do
it
'increments the prometheus counter'
do
expect
(
Gitlab
::
Metrics
).
to
receive
(
:counter
)
.
with
(
:pipelines_created_
count
,
"Pipelines created count
"
)
.
with
(
:pipelines_created_
total
,
"Counter of pipelines created
"
)
.
and_call_original
pipeline
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment