Commit e86923eb authored by Sean McGivern's avatar Sean McGivern

Merge branch...

Merge branch '45436-markdown-is-not-rendering-error-loading-viewer-undefined-method-html_escape' into 'master'

Resolve "Markdown is not rendering, "Error loading viewer": undefined method `html_escape'"

Closes #45436

See merge request gitlab-org/gitlab-ce!18418
parents bcd89dcd 11ec2f75
...@@ -90,7 +90,7 @@ module TreeHelper ...@@ -90,7 +90,7 @@ module TreeHelper
end end
def commit_in_single_accessible_branch def commit_in_single_accessible_branch
branch_name = html_escape(selected_branch) branch_name = ERB::Util.html_escape(selected_branch)
message = _("Your changes can be committed to %{branch_name} because a merge "\ message = _("Your changes can be committed to %{branch_name} because a merge "\
"request is open.") % { branch_name: "<strong>#{branch_name}</strong>" } "request is open.") % { branch_name: "<strong>#{branch_name}</strong>" }
......
---
title: Fix undefined `html_escape` method during markdown rendering
merge_request: 18418
author:
type: fixed
...@@ -9,7 +9,7 @@ module Banzai ...@@ -9,7 +9,7 @@ module Banzai
lang_attr = lang.present? ? %Q{ lang="#{lang}"} : '' lang_attr = lang.present? ? %Q{ lang="#{lang}"} : ''
result = result =
"<pre>" \ "<pre>" \
"<code#{lang_attr}>#{html_escape(code)}</code>" \ "<code#{lang_attr}>#{ERB::Util.html_escape(code)}</code>" \
"</pre>" "</pre>"
out(result) out(result)
......
...@@ -6,7 +6,7 @@ module Banzai ...@@ -6,7 +6,7 @@ module Banzai
lang_attr = lang ? %Q{ lang="#{lang}"} : '' lang_attr = lang ? %Q{ lang="#{lang}"} : ''
"\n<pre>" \ "\n<pre>" \
"<code#{lang_attr}>#{html_escape(code)}</code>" \ "<code#{lang_attr}>#{ERB::Util.html_escape(code)}</code>" \
"</pre>" "</pre>"
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment