Commit e93de606 authored by Ahmad Sherif's avatar Ahmad Sherif

Fix ProjectsFinder spec

Follow-up on 1003454c
parent 76db0dc1
...@@ -23,7 +23,6 @@ describe ProjectsFinder do ...@@ -23,7 +23,6 @@ describe ProjectsFinder do
let(:finder) { described_class.new } let(:finder) { described_class.new }
describe 'without a group' do
describe 'without a user' do describe 'without a user' do
subject { finder.execute } subject { finder.execute }
...@@ -43,51 +42,7 @@ describe ProjectsFinder do ...@@ -43,51 +42,7 @@ describe ProjectsFinder do
end end
it do it do
is_expected.to eq([public_project, internal_project, is_expected.to eq([public_project, internal_project, private_project])
private_project])
end
end
end
end
describe 'with a group' do
describe 'without a user' do
subject { finder.execute(nil, group: group) }
it { is_expected.to eq([public_project]) }
end
describe 'with a user' do
subject { finder.execute(user, group: group) }
describe 'without shared projects' do
it { is_expected.to eq([public_project, internal_project]) }
end
describe 'with shared projects and group membership' do
before do
group.add_user(user, Gitlab::Access::DEVELOPER)
shared_project.project_group_links.
create(group_access: Gitlab::Access::MASTER, group: group)
end
it do
is_expected.to eq([shared_project, public_project, internal_project])
end
end
describe 'with shared projects and project membership' do
before do
shared_project.team.add_user(user, Gitlab::Access::DEVELOPER)
shared_project.project_group_links.
create(group_access: Gitlab::Access::MASTER, group: group)
end
it do
is_expected.to eq([shared_project, public_project, internal_project])
end
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment